Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add brave://path to support deep linking to Search Engine edit popup in settings #42999

Open
6 tasks
bradleyrichter opened this issue Dec 19, 2024 · 0 comments
Open
6 tasks

Comments

@bradleyrichter
Copy link

Description

In order to open the proper dialog allowing users to change their default search engine, we need to add a deep link path to the settings popup.

This change is dependent on this issue which will allow for targeting the correct popup depending on normal or private settings.

#42990

Steps to reproduce

try to use the path: brave://settings/search

notice it doesn't open the popup behind the Change button

Actual result

no path to open sub dialog

Expected result

link available to this page:

Image

Reproduces how often

Easily reproduced

Brave version (brave://version info)

all versions

Channel information

  • release (stable)
  • beta
  • nightly

Reproducibility

  • with Brave Shields disabled
  • with Brave Rewards disabled
  • in the latest version of Chrome

Miscellaneous information

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants