Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Follow up to PR [26551] - Inconsistencies found in the internal pages #42997

Open
1 of 6 tasks
MadhaviSeelam opened this issue Dec 19, 2024 · 1 comment
Open
1 of 6 tasks

Comments

@MadhaviSeelam
Copy link

Description

Found while verifying the PR brave/brave-core#26551. Found few inconsistencies in the internal pages

  1. brave://settings/braveSync/setup - Subtitles font is bigger than Page titles
  2. brave://extensions/shortcuts & brave://extensions/ - page titles either missing or doesn't match with Figma

Steps to reproduce

  1. Install 1.75.112
  2. launch Brae
  3. open few internal pages - brave://settings/searchEngines, brave://settings/braveSync/setup,brave://extensions/shortcuts, brave://extensions/

Actual result

Inconsistency in the subtitle font

brave://settings/braveSync/setup brave://extensions/shortcuts brave://extensions
Image Image Image

Expected result

Internal pages should match to Figma

brave://settings/braveSync/setup brave://extensions/shortcuts brave://extensions
Image Image Image

Reproduces how often

Easily reproduced

Brave version (brave://version info)

Brave 1.75.112 Chromium: 132.0.6834.46 (Official Build) nightly (64-bit)
Revision f1de7e60955b06e067a605adca9d6a87d6142baf
OS Windows 11 Version 24H2 (Build 26100.2314)

Channel information

  • release (stable)
  • beta
  • nightly

Reproducibility

  • with Brave Shields disabled
  • with Brave Rewards disabled
  • in the latest version of Chrome

Miscellaneous information

@aguscruiz @rebron

@aguscruiz
Copy link

The one from brave://settings/braveSync/setup I think it's working as expected.

The other two I would leave as is in order to no complcate the code too much, but if we can add the same page structure as the other pages, with the gray background for the page and all, that'd be ideal.

But can wait since it's the same issue as bookmarks, history, download have.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: No status
Status: No status
Development

No branches or pull requests

2 participants