Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Nightly] Private window search using context menu uses default engine instead of engine selected for private window #42989

Open
1 of 6 tasks
Brave-Matt opened this issue Dec 19, 2024 · 0 comments

Comments

@Brave-Matt
Copy link

Brave-Matt commented Dec 19, 2024

Description

On Brave Nightly (1.75.112) there is an error with the default search engines — when Nightly private window engine is selected, selecting text and using the Search ____ for… option in the context menu searches using the default engine, not the one set to be used in Nightly. Note that this occurs regardless of which Search engines you have set as the defaults:

Screen.Recording.2024-12-19.at.10.19.03.AM.mov

Steps to reproduce

  1. Set normal window Search engine to Brave
  2. Set private window search engine to DDG
  3. Open private window, select some text and select Search DDG for... option from context menu

Actual result

Text is searched on the engine set for use in the normal window, not private window

Expected result

Selected text should be searched using the default engine set to be used for private windows

Reproduces how often

Easily reproduced

Brave version (brave://version info)

Always

Channel information

  • release (stable)
  • beta
  • nightly

Reproducibility

  • with Brave Shields disabled
  • with Brave Rewards disabled
  • in the latest version of Chrome

Miscellaneous information

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant