Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[iOS] - Fix continuation leak in AlertPopupView #42986

Open
3 of 5 tasks
Brandon-T opened this issue Dec 19, 2024 · 0 comments · May be fixed by brave/brave-core#27069
Open
3 of 5 tasks

[iOS] - Fix continuation leak in AlertPopupView #42986

Brandon-T opened this issue Dec 19, 2024 · 0 comments · May be fixed by brave/brave-core#27069
Assignees
@Brandon-T
Labels
OS/iOS Fixes related to iOS browser functionality QA/Yes release-notes/exclude

Comments

@Brandon-T
Copy link

Description

  • AlertPopupView can leak the continuation when WebKit cancels the requests or starts another request while the popup is displayed.

Steps to reproduce

  1. https://hackerone.com/reports/2909560

Actual result

  • Popup is shown on the wrong page

Expected result

  • Popup should show not show

Reproduces how often

Easily reproduced

Brave version

  • All

Device/iOS version

  • All

Affected browser versions

  • latest AppStore
  • latest TestFlight
  • previous TestFlight

Reproducibility

  • with Brave Shields disabled
  • in the latest version of mobile Safari

Miscellaneous information

No response
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Brandon-T Brandon-T

Labels
OS/iOS Fixes related to iOS browser functionality QA/Yes release-notes/exclude
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[iOS] - Fix alert continuation leak when WebKit automatically cancels the request brave/brave-core
1 participant
@Brandon-T