Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjusted split view tile and its tabs padding/margin #27024

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

simonhong
Copy link
Member

@simonhong simonhong commented Dec 16, 2024

fix brave/brave-browser#42913
fix brave/brave-browser#42972

Horizontal tab:
Screenshot 2024-12-18 101834
Screenshot 2024-12-18 101911
Screenshot 2024-12-18 101922
Screenshot 2024-12-18 101929
Screenshot 2024-12-18 101941


Vertical tab:

Screenshot 2024-12-18 153412
Screenshot 2024-12-18 153605
Screenshot 2024-12-18 153621
Screenshot 2024-12-18 153633

4px between split view tile and others
Screenshot 2024-12-19 200955

Resolves

Submitter Checklist:

  • I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

SplitViewBrowserTest.SplitViewTabPathTest

@simonhong simonhong self-assigned this Dec 16, 2024
@simonhong simonhong force-pushed the adjust_split_view_tab_layout branch 6 times, most recently from 2c81d8d to f992d89 Compare December 19, 2024 11:06
@simonhong simonhong force-pushed the adjust_split_view_tab_layout branch from f992d89 to e4b5445 Compare December 19, 2024 12:13
@simonhong simonhong marked this pull request as ready for review December 20, 2024 01:34
Copy link
Collaborator

@aguscruiz aguscruiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved! ⭐️⭐️⭐️⭐️⭐️ 👑

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Split view tab tile also should have gap with other tab Update split view tab's bounds/padding
2 participants