Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use hover color for a tab in split view #42879

Closed
3 of 6 tasks
simonhong opened this issue Dec 13, 2024 · 1 comment · Fixed by brave/brave-core#27008
Closed
3 of 6 tasks

Use hover color for a tab in split view #42879

simonhong opened this issue Dec 13, 2024 · 1 comment · Fixed by brave/brave-core#27008
Assignees
@simonhong
Labels
OS/Desktop QA/No release-notes/exclude split view
Milestone
1.75.x - Beta

Comments

@simonhong
Copy link
Member

Description

Part of #39027

Image

Steps to reproduce

  1. Enable split view feature and restart
  2. Create split view
  3. Mouse over any inactive tab in split view

Actual result

No background change when hovered

Expected result

Changed background color when hovered

Reproduces how often

Easily reproduced

Brave version (brave://version info)

1.75.95 Chromium: 132.0.6834.46 (Official Build) nightly (arm64)

Channel information

  • release (stable)
  • beta
  • nightly

Reproducibility

  • with Brave Shields disabled
  • with Brave Rewards disabled
  • in the latest version of Chrome

Miscellaneous information

cc @rebron @aguscruiz
@simonhong simonhong self-assigned this Dec 13, 2024
@simonhong
Copy link
Member Author

Working on this.

simonhong added a commit to brave/brave-core that referenced this issue Dec 14, 2024
@simonhong
Updated active/hover bg color of inactive tab in split view
63e2244 
fix brave/brave-browser#42879
@simonhong simonhong mentioned this issue Dec 14, 2024
Merged
24 tasks
@brave-builds brave-builds added this to the 1.75.x - Nightly milestone Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@simonhong simonhong

Labels
OS/Desktop QA/No release-notes/exclude split view
Projects
Front End
Status: No status
Milestone
1.75.x - Beta
Development

Successfully merging a pull request may close this issue.

Re-style split view UI brave/brave-core
2 participants
@simonhong @brave-builds