Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ads] Disable NotificationAdPopupBrowserTest #42797

Closed
aseren opened this issue Dec 10, 2024 · 0 comments · Fixed by brave/brave-core#26960
Closed

[ads] Disable NotificationAdPopupBrowserTest #42797

aseren opened this issue Dec 10, 2024 · 0 comments · Fixed by brave/brave-core#26960
Assignees
@aseren
Labels
dev-concern feature/ads OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA/No release-notes/exclude
Milestone
1.73.x - Release #5

Comments

@aseren
Copy link

aseren commented Dec 10, 2024 •
edited
Loading

Need to disable NotificationAdPopupBrowserTest due to:

  • Custom notification ad feature is currently disabled
  • NotificationAdPopupBrowserTest gives different results on different versions of Windows, so it can fail on CI
@aseren aseren self-assigned this Dec 10, 2024
@aseren aseren added priority/P3 The next thing for us to work on. It'll ride the trains. dev-concern feature/ads OS/Desktop release-notes/exclude labels Dec 10, 2024
@aseren aseren added this to Ads Dec 10, 2024
@github-project-automation github-project-automation bot moved this to New issues in Ads Dec 10, 2024
@aseren aseren moved this from New issues to In progress in Ads Dec 10, 2024
@aseren aseren added the QA/No label Dec 10, 2024
@aseren aseren mentioned this issue Dec 10, 2024
Merged
24 tasks
@aseren aseren moved this from In progress to Review in Ads Dec 10, 2024
@github-project-automation github-project-automation bot moved this from Review to Done in Ads Dec 10, 2024
@brave-builds brave-builds added this to the 1.75.x - Nightly milestone Dec 10, 2024
This was referenced Dec 10, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aseren aseren

Labels
dev-concern feature/ads OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA/No release-notes/exclude
Projects
Ads
Status: Done
Milestone
1.73.x - Release #5
Development

Successfully merging a pull request may close this issue.

[ads] Disable NotificationAdPopupBrowserTest brave/brave-core
2 participants
@brave-builds @aseren