Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unpin group from bookmarks menu option is not working as expected #42666

Closed
1 of 6 tasks
GeetaSarvadnya opened this issue Dec 4, 2024 · 2 comments · Fixed by brave/brave-core#26864
Closed
1 of 6 tasks

Unpin group from bookmarks menu option is not working as expected #42666

GeetaSarvadnya opened this issue Dec 4, 2024 · 2 comments · Fixed by brave/brave-core#26864
Assignees
@emerick
Labels
bug OS/Desktop QA Pass-Win64 QA/Test-Plan-Specified QA/Yes release-notes/exclude
Milestone
1.74.x - Beta

Comments

@GeetaSarvadnya
Copy link

Description

Found while testing #41761
Unpin group from bookmarks menu option is not working as expected

Steps to reproduce

  1. Clean profile 1.75.69 CR132
  2. Click on hamburger menu
  3. Click on Tab group->mouse hover on created tab group->click on Unpin tab group from bookmarks
  4. Tab group is not unpinned from bookmarks

Actual result

Unpin group from bookmarks menu option is not working as expected
Image

Expected result

Should be able to unpin the tab group from bookmarks via hamburger menu

Reproduces how often

Easily reproduced

Brave version (brave://version info)

Brave 1.75.69 Chromium: 132.0.6834.15 (Official Build) nightly (64-bit)
Revision deb39c780c5ec5570f05476b4ebd60748abd3d23
OS Windows 10 Version 22H2 (Build 19045.5131)

Channel information

  • release (stable)
  • beta
  • nightly

Reproducibility

  • with Brave Shields disabled
  • with Brave Rewards disabled
  • in the latest version of Chrome

Miscellaneous information

cc: @brave/qa-team @emerick @rebron
@GeetaSarvadnya GeetaSarvadnya mentioned this issue Dec 4, 2024
Closed
@emerick emerick mentioned this issue Dec 4, 2024
Merged
24 tasks
@emerick emerick self-assigned this Dec 4, 2024
@brave-builds brave-builds added this to the 1.75.x - Nightly milestone Dec 5, 2024
@emerick emerick mentioned this issue Dec 5, 2024
Merged
24 tasks
@kjozwiak kjozwiak moved this to Completed in Settings Dec 6, 2024
@kjozwiak
Copy link
Member

kjozwiak commented Dec 6, 2024

The above requires 1.74.21 or higher for 1.74.x verification 👍

@MadhaviSeelam
Copy link

MadhaviSeelam commented Dec 10, 2024 •
edited
Loading

Verification PASSED using

Brave | 1.74.24 Chromium: 132.0.6834.33 (Official Build) beta (64-bit)
-- | --
Revision | 3f746b728dd340e7d438b026bddf72f4001c1088
OS | Windows 11 Version 24H2 (Build 26100.2314)

Confirmed Tab groups menu item is hidden in the hamburger menu

1.75.67 1.74.24
Image Image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@emerick emerick

Labels
bug OS/Desktop QA Pass-Win64 QA/Test-Plan-Specified QA/Yes release-notes/exclude
Projects
Settings
Status: Completed
Milestone
1.74.x - Beta
Development

Successfully merging a pull request may close this issue.

Fix broken tab group menu options brave/brave-core
5 participants
@kjozwiak @emerick @GeetaSarvadnya @brave-builds @MadhaviSeelam