[Leo full page] - Tweak to expand/collapse sidebar icons #42068

aguscruiz · 2024-11-04T17:32:46Z

Based on feedback that the current icon is the same one we use on vertical tabs (true, didn't notice), I changed the icons for expanding/collapsing the sidebar to the following:

sidenav-collapse
sidenav-expand

Test plan

Large window

Make the window wide enough that the conversation navigation is expanded automatically
Observe: collapse button icon should point left
Press the button
Observe: expand button icon should point right

Small window

Make the window narrow enough that the conversation navigation is contracted automatically
Observe: expand button icon should point right
Press the button
Observe: contract button icon should point left

https://www.figma.com/design/m0Gdbf0wtqyfEFGm32VLLc/%F0%9F%94%84-Leo-%5BIN-PROGRESS%5D?node-id=15-15519

- [AIChat conversation data storage by petemill · Pull Request \#25876 · brave/brave-core](#25876) - [AI Chat conversations should persist browser restart · Issue \#42800 · brave/brave-browser](brave/brave-browser#42800) `QA/Yes` - [\[AIChat\]: Add URL based routing for different chats by fallaciousreasoning · Pull Request \#26050 · brave/brave-core](#26050) - [\[AI Chat\]: URLs for all conversations · Issue \#42055 · brave/brave-browser](brave/brave-browser#42055) `QA/Yes` - test plan: url and header variations specified - [AI Chat fullpage UI notices and polish by petemill · Pull Request \#26678 · brave/brave-core](#26678) - [AI Chat conversation list should prompt to enable history storage if it's disabled · Issue \#42576 · brave/brave-browser](brave/brave-browser#42576) `QA/Yes` - test plan: specified - [AI Chat notice for conversation storage · Issue \#42360 · brave/brave-browser](brave/brave-browser#42360) `QA/Yes` - test plan: specified - [AI Chat FullPage shouldn't show in SidePanel mode when restored at startup · Issue \#42413 · brave/brave-browser](brave/brave-browser#42413) `QA/Yes` - test plan: specified - [AI Chat becomes a trusted WebUI with an UntrustedWebUI frame for LLM-generated responses by petemill · Pull Request \#26855 · brave/brave-core](#26855) - [Change AI Chat url to chrome://leo-ai · Issue \#42817 · brave/brave-browser](brave/brave-browser#42817) `QA/Yes` - [AI Chat conversation entries should be isolated in an untrusted frame · Issue \#42818 · brave/brave-browser](brave/brave-browser#42818) `QA/No` - [\[AI Chat\]: Update copy button label by fallaciousreasoning · Pull Request \#26422 · brave/brave-core](#26422) - [Change copy button name to text if text in code block · Issue \#42117 · brave/brave-browser](brave/brave-browser#42117) `QA/Yes` - [\[AI Chat\]: Conversation starter pack, for unassociated content by fallaciousreasoning · Pull Request \#26379 · brave/brave-core](#26379) - [\[AI Chat\]: Add support for static conversation starters · Issue \#42106 · brave/brave-browser](brave/brave-browser#42106) `QA/Yes` - test plan: needs improvement - [Css tweaks and icon change for sidebar by aguscruiz · Pull Request \#26450 · brave/brave-core](#26450) - [\[Leo full page\] - Tweak to expand/collapse sidebar icons · Issue \#42068 · brave/brave-browser](brave/brave-browser#42068) `QA/Yes` - test plan: specified (check icons are correct) - [\[AI Chat\]: Update styling on suggestions by fallaciousreasoning · Pull Request \#26565 · brave/brave-core](#26565) - [\[AI Chat\]: Update suggestions style to match new design · Issue \#42107 · brave/brave-browser](brave/brave-browser#42107) `QA/Yes` - test plan: specified (check suggestions have new style) - [\[AI Chat\]: Don't show starter suggestions on non-empty chats by fallaciousreasoning · Pull Request \#26677 · brave/brave-core](#26677) - [AI Chat static conversation starters shouldn't show if conversation has chat history · Issue \#42412 · brave/brave-browser](brave/brave-browser#42412) `QA/Yes` - test plan: specified (verify conversation starters only show when applicable) - [fix hit area for leo conversations list by aguscruiz · Pull Request \#26793 · brave/brave-core](#26793) - [Leo full page - Conversation list - Make the whole item clickable instead of excluding the padding · Issue \#42552 · brave/brave-browser](brave/brave-browser#42552) `QA/No` - [\[Nala / @brave/leo\] update dependency by petemill · Pull Request \#26767 · brave/brave-core](#26767) - brave/brave-browser#42545 `QA/No`

aguscruiz added browser-ai design A design change, especially one which needs input from the design team labels Nov 4, 2024

aguscruiz assigned mattmcalister and petemill Nov 4, 2024

rebron added the OS/Desktop label Nov 6, 2024

rebron added this to Browser AI Nov 6, 2024

rebron added QA/Yes release-notes/exclude labels Nov 6, 2024

aguscruiz mentioned this issue Nov 8, 2024

Css tweaks and icon change for sidebar brave/brave-core#26450

Merged

24 tasks

aguscruiz self-assigned this Nov 12, 2024

aguscruiz closed this as completed in brave/brave-core#26450 Nov 13, 2024

github-project-automation bot moved this to Done in Browser AI Nov 13, 2024

brave-builds added feature/web3/wallet Integrating Ethereum+ wallet support feature/web3/wallet/core labels Nov 13, 2024

brave-builds added this to the 1.75.x - Nightly milestone Nov 13, 2024

petemill removed the feature/web3/wallet/core label Dec 10, 2024

petemill mentioned this issue Dec 11, 2024

AI Chat Full Page Storage feature (uplift to 1.74.x) brave/brave-core#26977

Closed

srirambv removed the feature/web3/wallet Integrating Ethereum+ wallet support label Dec 16, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Leo full page] - Tweak to expand/collapse sidebar icons #42068

[Leo full page] - Tweak to expand/collapse sidebar icons #42068

aguscruiz commented Nov 4, 2024 •

edited by petemill

Loading

[Leo full page] - Tweak to expand/collapse sidebar icons #42068

[Leo full page] - Tweak to expand/collapse sidebar icons #42068

Comments

aguscruiz commented Nov 4, 2024 • edited by petemill Loading

Test plan

Large window

Small window

aguscruiz commented Nov 4, 2024 •

edited by petemill

Loading