Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Split view mini URL view is truncating in the wrong direction #42011

Closed
diracdeltas opened this issue Oct 31, 2024 · 2 comments · Fixed by brave/brave-core#26452
Closed

Split view mini URL view is truncating in the wrong direction #42011

diracdeltas opened this issue Oct 31, 2024 · 2 comments · Fixed by brave/brave-core#26452
Assignees
@bridiver @simonhong
Labels
OS/Desktop priority/P2 A bad problem. We might uplift this to the next planned release. QA/Test-All-Platforms QA/Yes release-notes/exclude security split view
Milestone
1.75.x - Nightly

Comments

@diracdeltas
Copy link
Member

in the security review for split view, we asked for a mini URL view on the inactive split. when the URL is too long to fit in the entire view, it truncates from the beginning of the URL. it should instead truncate from the end so that the URL origin is visible OR only show the URL origin.

Image
@diracdeltas diracdeltas added OS/Desktop priority/P2 A bad problem. We might uplift this to the next planned release. security labels Oct 31, 2024
@thypon
Copy link
Member

thypon commented Oct 31, 2024

Alternatively we should just show the eTLD+1

@rebron rebron moved this to On Deck in Front End Nov 4, 2024
@simonhong simonhong mentioned this issue Nov 8, 2024
Merged
24 tasks
@simonhong simonhong moved this from On Deck to In progress in Front End Nov 8, 2024
@brave-builds brave-builds added this to the 1.75.x - Nightly milestone Nov 9, 2024
@rebron rebron moved this from In progress to Completed in Front End Nov 12, 2024
@rebron rebron changed the title split view mini URL view is truncating in the wrong direction Split view mini URL view is truncating in the wrong direction Dec 10, 2024
@LaurenWags
Copy link
Member

Added QA/Test-All-Platforms since this is a security issue 👍🏻

cc @kjozwiak

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bridiver bridiver

@simonhong simonhong

Labels
OS/Desktop priority/P2 A bad problem. We might uplift this to the next planned release. QA/Test-All-Platforms QA/Yes release-notes/exclude security split view
Projects
Front End
Status: Completed
Milestone
1.75.x - Nightly
Development

Successfully merging a pull request may close this issue.

Elide split view's url at the end brave/brave-core
7 participants
@bridiver @diracdeltas @thypon @rebron @simonhong @LaurenWags @brave-builds