-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move handling mojom::BatAdsClient from UI thread #41632
Comments
@tmancey perhaps this could be P2 - the user impact is pretty visible (so i assume this not merely dev concern, but a product bug, when reproduced) |
Why are we returning such a large amount of data from the DB in the first place vs paginating the results or doing aggregations in SQL? |
@iefremov because this to my knowledge only occurred after a recent migration path, we added as a P3 which will be fixed before we bump the database version again. If this has changed we can move to a P2. |
I will run some perf tests locally using chrome://tracing. Thanks |
The trace from the perf pre test when we have this long UI task. |
As investigated in #41549 decoding
DBTransactionInfo
mojo messages happens on UI thread.In some real-world scenarios it could takes 30ms+ even on high-perf m1 machines resulting in hanging UI thread.
That code need to be move from UI or replace to a one without mojom-encoding/decoding (as @aseren suggested in the thread).
slack thread: https://bravesoftware.slack.com/archives/C3T9S9WKD/p1728567272430889
The text was updated successfully, but these errors were encountered: