Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add title to Bookmarks side panel #32952

Closed
rebron opened this issue Sep 13, 2023 · 0 comments · Fixed by brave/brave-core#20211
Closed

Add title to Bookmarks side panel #32952

rebron opened this issue Sep 13, 2023 · 0 comments · Fixed by brave/brave-core#20211
Assignees
@simonhong
Labels
feature/bookmarks feature/sidebar Relating to Brave's Sidebar feature OS/Desktop polish Nice to have — usually related to front-end/visual tasks priority/P4 Planned work. We expect to get to it "soon". QA/No release-notes/include
Milestone
1.60.x - Release

Comments

@rebron
Copy link
Collaborator

rebron commented Sep 13, 2023 •
edited
Loading

Description

Add icon and title to bookmarks side panel

Figma link: https://www.figma.com/file/RV4KVz8dBmHuF7ORm7yO2y/Bookmarks-panel-and-manager?type=design&node-id=1-25&mode=design

Expected result:

Screenshot 2023-09-12 at 6 57 48 PM

Brave version (brave://version info)

Target 1.60.x

Version/Channel Information:

  • Can you reproduce this issue with the current release? n/a
  • Can you reproduce this issue with the beta channel? n/a
  • Can you reproduce this issue with the nightly channel? n/a

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? n/a
  • Does the issue resolve itself when disabling Brave Rewards? n/a
  • Is the issue reproducible on the latest version of Chrome? n/a

Miscellaneous Information:

cc: @minkyeongshin
@rebron rebron added feature/bookmarks polish Nice to have — usually related to front-end/visual tasks priority/P4 Planned work. We expect to get to it "soon". OS/Desktop feature/sidebar Relating to Brave's Sidebar feature labels Sep 13, 2023
@simonhong simonhong mentioned this issue Sep 19, 2023
Merged
25 tasks
@simonhong simonhong linked a pull request Sep 19, 2023 that will close this issue
Added header to bookmarks panel brave/brave-core#20211
Merged
25 tasks
simonhong added a commit to brave/brave-core that referenced this issue Sep 20, 2023
@simonhong
Added header to bookmarks panel
f4c1efe 
fix brave/brave-browser#32952

Bookmarks panel's header includes icon, title and button for loading
bookmarks manager.
@brave-builds brave-builds added this to the 1.60.x - Nightly milestone Sep 22, 2023
@rebron rebron added the QA/No label Sep 23, 2023
@LaurenWags LaurenWags mentioned this issue Nov 1, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@simonhong simonhong

Labels
feature/bookmarks feature/sidebar Relating to Brave's Sidebar feature OS/Desktop polish Nice to have — usually related to front-end/visual tasks priority/P4 Planned work. We expect to get to it "soon". QA/No release-notes/include
Projects
None yet
Milestone
1.60.x - Release
Development

Successfully merging a pull request may close this issue.

Added header to bookmarks panel brave/brave-core
3 participants
@rebron @simonhong @brave-builds