You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Sep 2, 2022. It is now read-only.
At the moment the authenticator isn't used in case of a failed login so it makes little sense to let types that implement the Authenticator trait return a reference to themselves when the login has failed.
This makes even less sense if you consider that the authenticator must be able to return a User type and thus must embed that within, but if the authentication failed such type cannot always be constructed.
Thus I propose to let the function return something else for the Error variant of the result.
The text was updated successfully, but these errors were encountered:
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
At the moment the authenticator isn't used in case of a failed login so it makes little sense to let types that implement the
Authenticator
trait return a reference to themselves when the login has failed.This makes even less sense if you consider that the authenticator must be able to return a
User
type and thus must embed that within, but if the authentication failed such type cannot always be constructed.Thus I propose to let the function return something else for the
Error
variant of the result.The text was updated successfully, but these errors were encountered: