Skip to content
This repository has been archived by the owner on Sep 2, 2022. It is now read-only.

Returning the authenticator on failed login #6

Open
bramvdbogaerde opened this issue Mar 12, 2018 · 0 comments
Open

Returning the authenticator on failed login #6

bramvdbogaerde opened this issue Mar 12, 2018 · 0 comments

Comments

@bramvdbogaerde
Copy link
Owner

bramvdbogaerde commented Mar 12, 2018

At the moment the authenticator isn't used in case of a failed login so it makes little sense to let types that implement the Authenticator trait return a reference to themselves when the login has failed.

This makes even less sense if you consider that the authenticator must be able to return a User type and thus must embed that within, but if the authentication failed such type cannot always be constructed.

Thus I propose to let the function return something else for the Error variant of the result.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant