Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make module express their features #904

Open
sthibaul opened this issue Apr 28, 2024 · 0 comments
Open

Make module express their features #904

sthibaul opened this issue Apr 28, 2024 · 0 comments

Comments

@sthibaul
Copy link
Collaborator

sthibaul commented Apr 28, 2024

Is your feature request related to a problem? Please describe.
The server code has hardcoded lists such as

		int punct_missing = 0;
		if (strcmp(output->name, "flite") == 0 ||
		    strcmp(output->name, "dtk-generic") == 0 ||
		    strcmp(output->name, "epos-generic") == 0 ||
		    strcmp(output->name, "llia_phon-generic") == 0 ||
		    strcmp(output->name, "mary-generic") == 0 ||
		    strcmp(output->name, "swift-generic") == 0 ||
		    strcmp(output->name, "pico") == 0)
			/* These don't support punctuation */
			/* FIXME: rather make them express it */
			punct_missing = 1;

Describe the solution you'd like
The modules should expose their features to the server. We'd want that after initialization. This could be a new command that the server sends to the module to get a feature list, which could be a mere list of lines. The features that the server doesn't understand can be ignored, and if the client says it doesn't support the command, we can assume that it doesn't support the features.

That would probably be useful for exposing the punctuation support as mentioned above, but also ssml support, see #905

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant