Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

user configuration errors should be papered over #883

Open
sthibaul opened this issue Mar 17, 2024 · 0 comments
Open

user configuration errors should be papered over #883

sthibaul opened this issue Mar 17, 2024 · 0 comments

Comments

@sthibaul
Copy link
Collaborator

Reported by @albertotirla

Steps to reproduce

Not sure how, just reporting here what was said on matrix.

Obtained behavior

“when the tinyest thing is wrong in sd's configuration, it doesn't just remove that module with a warning, fallback to defaults, any of that, but instead it entirely crashes, leaving the user with absolutely no speech”

Expected behavior

spd should always at least produce speech, whatever configuration error the user may have done.

Of course, it the user directed speech to an audio card whose headphones are not connected, spd can't do much, but there are probably various situations where spd detects an error, and should be able to fallback on something that works.

@sthibaul sthibaul changed the title crash not recovered properly configuration errors should be papered over Mar 17, 2024
@sthibaul sthibaul changed the title configuration errors should be papered over user configuration errors should be papered over Mar 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant