Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generic speech dispatcher does not respect voice type #873

Open
gaycodegal opened this issue Feb 17, 2024 · 1 comment
Open

Generic speech dispatcher does not respect voice type #873

gaycodegal opened this issue Feb 17, 2024 · 1 comment
Labels

Comments

@gaycodegal
Copy link

gaycodegal commented Feb 17, 2024

if you run

spd-say -L

the variants listed there are actually not usable with --voice-type parameter. I would assume they were meant to.

Further, if you set a supported voice type from the hardcoded list of 8, this has no effect on the speech dispatcher defined in generic.c; this is true even if you name voice variants after the hardcoded list of 8.

I propose, if a voice is listed with a name in the spd-say -L table, say.c should set the voice (-y) parameter automatically to the associated name.

So if I have

AddVoice "en-US" "male2"   "awb"

and type in

spd-say -t male2 hi

I would expect this to behave identically to

spd-say -y awb -t male2 hi

I am offering to fix this in the code myself, Im just making an issue in case anyone has comments on this.

I am also planning on making this generic so even if its not in the hardcoded list of 8 and the user has configured it with reasonable values, it will still work.

For instance

AddVoice "en-US" "alien1"   "kal16"

would work with command

spd-say -t alien1 hi

and behave identically to the command

spd-say -y kal16 hi

(-t is omitted because currently invalid -t parameters yield a printed error, and I would not do this if I find a suitable match)

@sthibaul
Copy link
Collaborator

the variants listed there are actually not usable with --voice-type parameter

Are they not? Trying to use espeak-mbrola-generic with speechd 0.11.5 here:

$ spd-say -o espeak-mbrola-generic -t male1 foo
$ spd-say -o espeak-mbrola-generic -t female1 foo

do select the type properly.

I am offering to fix this in the code myself

You are welcome :) That may clear out what issue you are actually encountering.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants