-
Notifications
You must be signed in to change notification settings - Fork 109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Table component demo data is being added when importing an edited table #997
Labels
bug
Something isn't working
Comments
1 task
bpmn-io-tasks
bot
added
needs review
Review pending
and removed
in progress
Currently worked on
labels
Jan 25, 2024
Skaiir
pushed a commit
that referenced
this issue
Jan 30, 2024
Skaiir
pushed a commit
that referenced
this issue
Jan 30, 2024
vsgoulart
added a commit
that referenced
this issue
Jan 31, 2024
* chore: update actions/setup-node digest to d86ebcd (#967) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * fix(markdown): add margins to all markdown elements (#986) * fix: improve image editor placeholder styles Related to #994 * chore: adjust iframe placeholder font size Related to #994 * feat: add `security` properties for iFrame Closes #901 * feat: add warning step to iframe security attributes config Related to #901 * fix: show iframe title in the editor Closes #990 * chore(CHANGELOG): correct minor formatting issues (#1003) * chore: update actions/cache action to v4 (#995) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore: update actions/upload-artifact digest to 26f96df (#979) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * fix: repeatable entry parameters now validate with errors Closes #966 * feat: implement number field debouncing Closes #958 * chore: remove superfluous useEffects Related to #958 * fix: Prevent demo data from being created on edited tables Closes #997 * chore: Add experimental tag Related to #997 * chore: update actions/upload-artifact digest to d00351b (#1014) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * feat: implement HTML display component Closes #1004 * feat(schema): support HTML component Related to #1004 * chore: remove our dependency on preact-markup Related to #1004 * fix: limit cm-editor properties height to 400px Related to #1004 * chore: cleanup html and text components Related to #1004 * fix: handle native CSS scoping & added tests #1004 * chore: updated snapshots * chore: Update deps (#1008) * chore: Update deps * chore: Revert properties panel update * chore: update dependency source-map-loader to v5 (#988) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore: replace dependency npm-run-all with npm-run-all2 ^5.0.0 (#1012) * chore: replace dependency npm-run-all with npm-run-all2 ^5.0.0 * chore: Update to 6.1.1 --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Vinicius Goulart <[email protected]> * fix: resize textarea on input changes (#1017) Closes #1011 --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: bpmn-io-bot <[email protected]> Co-authored-by: Douglas Bouttell <[email protected]> Co-authored-by: Vinicius Goulart <[email protected]> Co-authored-by: Niklas Kiefer <[email protected]> Co-authored-by: Nico Rehwaldt <[email protected]> Co-authored-by: Skaiir <[email protected]>
Skaiir
pushed a commit
that referenced
this issue
Jan 31, 2024
Skaiir
pushed a commit
that referenced
this issue
Jan 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the Bug
When we added the table component we added feature of creating some initial table component, but with that we added the bug that creates this initial demo data on a table component that was edited via properties panel, we should avoid creating demo data on edited tables because we can't guarantee the table has compatible columns.
Steps to Reproduce
dataSource
via properties panelid
and not on thedataSource
Expected Behavior
Create the initial demo data only if the
dataSource
has the same value as theid
and only if the columns are compatible with the demo dataEnvironment
The text was updated successfully, but these errors were encountered: