Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show iframe title in editor #990

Closed
Skaiir opened this issue Jan 16, 2024 · 0 comments · Fixed by #991
Closed

Show iframe title in editor #990

Skaiir opened this issue Jan 16, 2024 · 0 comments · Fixed by #991
Assignees
@Skaiir
Labels
enhancement New feature or request spring cleaning Could be cleaned up one day

Comments

@Skaiir
Copy link
Contributor

Skaiir commented Jan 16, 2024

Is your feature request related to a problem? Please describe.

It's hard to know what an iframe is doing in the editor at a glace, showing the title would help with that. It also would be more consistent with the output.

Describe the solution you'd like

Simply render the label over the iframe.

Describe alternatives you've considered

n/a

Additional context

This has been discussed with design and approved.
@Skaiir Skaiir added enhancement New feature or request in progress Currently worked on spring cleaning Could be cleaned up one day labels Jan 16, 2024
@Skaiir Skaiir self-assigned this Jan 16, 2024
Skaiir added a commit that referenced this issue Jan 16, 2024
@Skaiir
fix: show iframe title in the editor
78f56b7 
Closes #990
@Skaiir Skaiir mentioned this issue Jan 16, 2024
Merged
@bpmn-io-tasks bpmn-io-tasks bot added needs review Review pending in progress Currently worked on and removed in progress Currently worked on needs review Review pending labels Jan 16, 2024
Skaiir added a commit that referenced this issue Jan 23, 2024
@Skaiir
fix: show iframe title in the editor
8fa38d8 
Closes #990
Skaiir added a commit that referenced this issue Jan 23, 2024
@Skaiir
fix: show iframe title in the editor
a070f91 
Closes #990
@bpmn-io-tasks bpmn-io-tasks bot added needs review Review pending and removed in progress Currently worked on labels Jan 23, 2024
Skaiir added a commit that referenced this issue Jan 23, 2024
@Skaiir
fix: show iframe title in the editor
42f4a88 
Closes #990
@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label Jan 23, 2024
vsgoulart added a commit that referenced this issue Jan 31, 2024
@Skaiir @renovate
@bpmn-io-bot @douglasbouttell-camunda @vsgoulart @nikku
merge dev to master (prep for 1.7) (#1018)
83b0fe5 
* chore: update actions/setup-node digest to d86ebcd (#967)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* fix(markdown): add margins to all markdown elements (#986)

* fix: improve image editor placeholder styles

Related to #994

* chore: adjust iframe placeholder font size

Related to #994

* feat: add `security` properties for iFrame

Closes #901

* feat: add warning step to iframe security attributes config

Related to #901

* fix: show iframe title in the editor

Closes #990

* chore(CHANGELOG): correct minor formatting issues (#1003)

* chore: update actions/cache action to v4 (#995)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* chore: update actions/upload-artifact digest to 26f96df (#979)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* fix: repeatable entry parameters now validate with errors

Closes #966

* feat: implement number field debouncing

Closes #958

* chore: remove superfluous useEffects

Related to #958

* fix: Prevent demo data from being created on edited tables

Closes #997

* chore: Add experimental tag

Related to #997

* chore: update actions/upload-artifact digest to d00351b (#1014)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* feat: implement HTML display component

Closes #1004

* feat(schema): support HTML component

Related to #1004

* chore: remove our dependency on preact-markup

Related to #1004

* fix: limit cm-editor properties height to 400px

Related to #1004

* chore: cleanup html and text components

Related to #1004

* fix: handle native CSS scoping & added tests

#1004

* chore: updated snapshots

* chore: Update deps (#1008)

* chore: Update deps

* chore: Revert properties panel update

* chore: update dependency source-map-loader to v5 (#988)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* chore: replace dependency npm-run-all with npm-run-all2 ^5.0.0 (#1012)

* chore: replace dependency npm-run-all with npm-run-all2 ^5.0.0

* chore: Update to 6.1.1

---------

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Vinicius Goulart <[email protected]>

* fix: resize textarea on input changes (#1017)

Closes #1011

---------

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: bpmn-io-bot <[email protected]>
Co-authored-by: Douglas Bouttell <[email protected]>
Co-authored-by: Vinicius Goulart <[email protected]>
Co-authored-by: Niklas Kiefer <[email protected]>
Co-authored-by: Nico Rehwaldt <[email protected]>
Co-authored-by: Skaiir <[email protected]>
Skaiir added a commit that referenced this issue Jan 31, 2024
@Skaiir
fix: show iframe title in the editor
cb48fcc 
Closes #990
Skaiir added a commit that referenced this issue Jan 31, 2024
@Skaiir
fix: show iframe title in the editor
c8738d0 
Closes #990
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Skaiir Skaiir

Labels
enhancement New feature or request spring cleaning Could be cleaned up one day
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: show iframe title in editor bpmn-io/form-js
1 participant
@Skaiir