Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validation feel expressions do not respect local context #1147

Closed
Skaiir opened this issue Apr 11, 2024 · 1 comment
Closed

Validation feel expressions do not respect local context #1147

Skaiir opened this issue Apr 11, 2024 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@Skaiir
Copy link
Contributor

Skaiir commented Apr 11, 2024

Describe the Bug

image

At the moment we evaluate feel expressions in the validation parameters not against the local context of the field being validated, but the root data context. This is incorrect and makes using feel validations in dynamic lists not work as expected.

Steps to Reproduce

  1. add a feel validation on a child of a dynamic list
  2. it is not possible to use this.value, or any of the context related values here

Expected Behavior

  1. feel expressions should evaluate within the local context
@Skaiir Skaiir added bug Something isn't working in progress Currently worked on labels Apr 11, 2024
@Skaiir Skaiir self-assigned this Apr 11, 2024
Skaiir added a commit that referenced this issue Apr 11, 2024
Skaiir added a commit that referenced this issue Apr 11, 2024
Skaiir added a commit that referenced this issue Apr 11, 2024
Skaiir added a commit that referenced this issue Apr 11, 2024
Skaiir added a commit that referenced this issue Apr 16, 2024
Skaiir added a commit that referenced this issue Apr 16, 2024
Skaiir added a commit that referenced this issue Apr 16, 2024
Skaiir added a commit that referenced this issue Apr 16, 2024
Skaiir added a commit that referenced this issue Apr 16, 2024
Skaiir added a commit that referenced this issue Apr 16, 2024
Skaiir added a commit that referenced this issue Apr 17, 2024
Skaiir added a commit that referenced this issue Apr 17, 2024
Skaiir added a commit that referenced this issue Apr 17, 2024
Skaiir added a commit that referenced this issue Apr 17, 2024
Skaiir added a commit that referenced this issue Apr 17, 2024
Skaiir added a commit that referenced this issue Apr 17, 2024
Skaiir added a commit that referenced this issue Apr 17, 2024
Skaiir added a commit that referenced this issue Apr 17, 2024
Skaiir added a commit that referenced this issue Apr 17, 2024
Skaiir added a commit that referenced this issue Apr 17, 2024
Skaiir added a commit that referenced this issue Apr 17, 2024
Skaiir added a commit that referenced this issue Apr 17, 2024
@bpmn-io-tasks bpmn-io-tasks bot added needs review Review pending and removed in progress Currently worked on labels Apr 17, 2024
Skaiir added a commit that referenced this issue Apr 19, 2024
Skaiir added a commit that referenced this issue Apr 19, 2024
Skaiir added a commit that referenced this issue Apr 19, 2024
Skaiir added a commit that referenced this issue Apr 19, 2024
Skaiir added a commit that referenced this issue Apr 19, 2024
Skaiir added a commit that referenced this issue Apr 19, 2024
Skaiir added a commit that referenced this issue Apr 19, 2024
Skaiir added a commit that referenced this issue Apr 19, 2024
Skaiir added a commit that referenced this issue Apr 19, 2024
Skaiir added a commit that referenced this issue Apr 19, 2024
Skaiir added a commit that referenced this issue Apr 19, 2024
Skaiir added a commit that referenced this issue Apr 19, 2024
@Skaiir
Copy link
Contributor Author

Skaiir commented Apr 19, 2024

Closed via #1155

@Skaiir Skaiir closed this as completed Apr 19, 2024
@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label Apr 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant