Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a better way to work with individual formField instances #1142

Closed
Skaiir opened this issue Apr 10, 2024 · 0 comments · Fixed by #1143
Closed

Create a better way to work with individual formField instances #1142

Skaiir opened this issue Apr 10, 2024 · 0 comments · Fixed by #1143
Assignees
Labels
spring cleaning Could be cleaned up one day

Comments

@Skaiir
Copy link
Contributor

Skaiir commented Apr 10, 2024

What should we do?

We should create a module which tracks individual formfield instances in the viewer.

Why should we do it?

At the moment, it is incredibly difficult to programmatically interact with individual elements of a form outside of the preact render cycle. So things like validation force us to write rather complicated algorithms which basically just recomputes what preact gives us for free. We should, as part of the preact render cycle, expose an API which "saves" all that work rendering and can be used across the app for things like validation, expression evaluations, ect...

@Skaiir Skaiir added in progress Currently worked on spring cleaning Could be cleaned up one day labels Apr 10, 2024
@Skaiir Skaiir self-assigned this Apr 10, 2024
Skaiir added a commit that referenced this issue Apr 10, 2024
Skaiir added a commit that referenced this issue Apr 10, 2024
Skaiir added a commit that referenced this issue Apr 10, 2024
@bpmn-io-tasks bpmn-io-tasks bot added needs review Review pending and removed in progress Currently worked on labels Apr 10, 2024
Skaiir added a commit that referenced this issue Apr 10, 2024
@bpmn-io-tasks bpmn-io-tasks bot added in progress Currently worked on and removed needs review Review pending labels Apr 10, 2024
Skaiir added a commit that referenced this issue Apr 11, 2024
Skaiir added a commit that referenced this issue Apr 11, 2024
Skaiir added a commit that referenced this issue Apr 11, 2024
Skaiir added a commit that referenced this issue Apr 11, 2024
Skaiir added a commit that referenced this issue Apr 11, 2024
Skaiir added a commit that referenced this issue Apr 11, 2024
@bpmn-io-tasks bpmn-io-tasks bot added needs review Review pending and removed in progress Currently worked on labels Apr 11, 2024
Skaiir added a commit that referenced this issue Apr 12, 2024
Skaiir added a commit that referenced this issue Apr 12, 2024
Skaiir added a commit that referenced this issue Apr 12, 2024
@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label Apr 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
spring cleaning Could be cleaned up one day
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant