Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validate table cell values #1139

Closed
vsgoulart opened this issue Apr 10, 2024 · 1 comment
Closed

Validate table cell values #1139

vsgoulart opened this issue Apr 10, 2024 · 1 comment
Assignees
@Skaiir
Labels
bug Something isn't working spring cleaning Could be cleaned up one day

Comments

@vsgoulart
Copy link
Contributor

Describe the Bug

When a user tries to render table cell items as objects the form viewer breaks.

Steps to Reproduce

  1. Add a table
  2. Pass an object as a table cell value
  3. The viewer breaks

Expected Behavior

The viewer should not break

Environment

  • Host (Browser/Node version), if applicable: [e.g. MS Edge 18, Chrome 69, Node 10 LTS]
  • OS: [e.g. Windows 7]
  • Library version: [e.g. 2.0.0]
@vsgoulart vsgoulart added bug Something isn't working spring cleaning Could be cleaned up one day labels Apr 10, 2024
@nikku nikku added the backlog Queued in backlog label Jul 23, 2024 — with bpmn-io-tasks
@Skaiir Skaiir self-assigned this Sep 10, 2024
Skaiir added a commit that referenced this issue Sep 10, 2024
@Skaiir
fix: serialize object table cells using the JSON serializer
0001f89 
Closes #1139
@bpmn-io-tasks bpmn-io-tasks bot added in progress Currently worked on and removed backlog Queued in backlog labels Sep 10, 2024
@Skaiir Skaiir mentioned this issue Sep 10, 2024
Merged
@bpmn-io-tasks bpmn-io-tasks bot added needs review Review pending and removed in progress Currently worked on labels Sep 10, 2024
vsgoulart pushed a commit that referenced this issue Sep 10, 2024
@Skaiir @vsgoulart
fix: serialize object table cells using the JSON serializer
bd995e1 
Closes #1139
@Skaiir
Copy link
Contributor

Skaiir commented Sep 10, 2024

Closed via #1256

@Skaiir Skaiir closed this as completed Sep 10, 2024
@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label Sep 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Skaiir Skaiir

Labels
bug Something isn't working spring cleaning Could be cleaned up one day
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@nikku @vsgoulart @Skaiir