Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draw dashed outline in editor for groups with outline disabled #1084

Closed
christian-konrad opened this issue Mar 6, 2024 · 0 comments · Fixed by #1089
Closed

Draw dashed outline in editor for groups with outline disabled #1084

christian-konrad opened this issue Mar 6, 2024 · 0 comments · Fixed by #1089
Assignees

Comments

@christian-konrad
Copy link
Contributor

christian-konrad commented Mar 6, 2024

What should we do?

Draw dashed outline in editor for groups with outline disabled

Why should we do it?

When using nested groups w/o outlines, it's hard to identify, target, and click them in the editor.
While we hide the outline in the viewer, we can still hint it slightly in the editor to help form developers.

Current:
Bildschirmfoto 2024-03-06 um 11 28 34

Proposal:
Bildschirmfoto 2024-03-06 um 11 33 48

@nikku nikku added the backlog Queued in backlog label Mar 7, 2024 — with bpmn-io-tasks
@bpmn-io-tasks bpmn-io-tasks bot added the in progress Currently worked on label Mar 7, 2024
@bpmn-io-tasks bpmn-io-tasks bot removed the backlog Queued in backlog label Mar 7, 2024
@bpmn-io-tasks bpmn-io-tasks bot added needs review Review pending and removed in progress Currently worked on labels Mar 7, 2024
@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label Mar 18, 2024
vsgoulart pushed a commit that referenced this issue Apr 10, 2024
* chore: apply label sizing to json-editors

Closes #1078

* chore: updated snapshots

* fix: display groups with no outline with a dashed outline in the editor

Closes #1084

* chore: changed the iframe preview site in playground to example.com

Closes #1070

* feat: expression field viewer component

Related to #1073

* feat: expression field editor component

Related to #1073

* feat: expression field properties panel

Related to #1073

* chore: added a helper function to test properties panel structure

* chore: added expression field unit tests

Related to #1073

* chore: expression field schema changes

Related to #1073

* chore: playground root refactor / prevent double form load

Closes #1073
Related to #1076

* fix: ensure palette renderer is immediately initialised

Related to #1073

* chore: remove unreliable tests

Related to #1073

* chore: updated snapshots

* chore: update actions/add-to-project digest to 2e5cc85

---------

Co-authored-by: Valentin Serra <[email protected]>
Co-authored-by: Skaiir <[email protected]>
Co-authored-by: bpmn-io-bot <[email protected]>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants