Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change the iframe preview site #1070

Closed
Skaiir opened this issue Feb 23, 2024 · 0 comments
Closed

Change the iframe preview site #1070

Skaiir opened this issue Feb 23, 2024 · 0 comments
Assignees
@Skaiir
Labels
bug Something isn't working spring cleaning Could be cleaned up one day

Comments

@Skaiir
Copy link
Contributor

Skaiir commented Feb 23, 2024 •
edited
Loading

Describe the Bug

The bpmn.io website doesn't particularly like being rendered in iframes and throws a few errors, mostly around cross origin request, which can be disturbing during debugging. It makes sense thematically but maybe we would prefer not having errors in our most used debugging path.

Steps to Reproduce

  1. npm run start:playground
  2. look at the browser console, 7-11 errors are thrown all from the iframe

Expected Behavior

  1. our browser console should remain clean
@Skaiir Skaiir added bug Something isn't working backlog Queued in backlog spring cleaning Could be cleaned up one day labels Feb 23, 2024
@Skaiir Skaiir changed the title Change the iframe preview site. Change the iframe preview site Feb 23, 2024
Skaiir added a commit that referenced this issue Feb 27, 2024
@Skaiir
chore: changed the iframe preview site in playground to example.com
bd3a4c6 
Closes #1070
@Skaiir Skaiir mentioned this issue Feb 27, 2024
Closed
@bpmn-io-tasks bpmn-io-tasks bot added the in progress Currently worked on label Feb 27, 2024
@bpmn-io-tasks bpmn-io-tasks bot added needs review Review pending in progress Currently worked on and removed backlog Queued in backlog in progress Currently worked on needs review Review pending labels Feb 27, 2024
Skaiir added a commit that referenced this issue Mar 5, 2024
@Skaiir
chore: changed the iframe preview site in playground to example.com
c3f2c2f 
Closes #1070
Skaiir added a commit that referenced this issue Mar 6, 2024
@Skaiir
chore: changed the iframe preview site in playground to example.com
ecb2cc7 
Closes #1070
Skaiir added a commit that referenced this issue Mar 7, 2024
@Skaiir
chore: changed the iframe preview site in playground to example.com
864f68e 
Closes #1070
Skaiir added a commit that referenced this issue Mar 14, 2024
@Skaiir
chore: changed the iframe preview site in playground to example.com
7f9d767 
Closes #1070
@bpmn-io-tasks bpmn-io-tasks bot added in progress Currently worked on and removed needs review Review pending labels Mar 14, 2024
@Skaiir Skaiir closed this as completed in 017f187 Mar 20, 2024
@bpmn-io-tasks bpmn-io-tasks bot removed the in progress Currently worked on label Mar 20, 2024
Skaiir added a commit that referenced this issue Mar 26, 2024
@Skaiir
chore: changed the iframe preview site in playground to example.com
4464bbd 
Closes #1070
Skaiir added a commit that referenced this issue Mar 26, 2024
@Skaiir
chore: changed the iframe preview site in playground to example.com
5aaa32c 
Closes #1070
vsgoulart pushed a commit that referenced this issue Apr 10, 2024
@renovate @Skaiir @bpmn-io-bot
chore: update actions/add-to-project digest to 2e5cc85 (#1138)
6e7c461 
* chore: apply label sizing to json-editors

Closes #1078

* chore: updated snapshots

* fix: display groups with no outline with a dashed outline in the editor

Closes #1084

* chore: changed the iframe preview site in playground to example.com

Closes #1070

* feat: expression field viewer component

Related to #1073

* feat: expression field editor component

Related to #1073

* feat: expression field properties panel

Related to #1073

* chore: added a helper function to test properties panel structure

* chore: added expression field unit tests

Related to #1073

* chore: expression field schema changes

Related to #1073

* chore: playground root refactor / prevent double form load

Closes #1073
Related to #1076

* fix: ensure palette renderer is immediately initialised

Related to #1073

* chore: remove unreliable tests

Related to #1073

* chore: updated snapshots

* chore: update actions/add-to-project digest to 2e5cc85

---------

Co-authored-by: Valentin Serra <[email protected]>
Co-authored-by: Skaiir <[email protected]>
Co-authored-by: bpmn-io-bot <[email protected]>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Skaiir Skaiir

Labels
bug Something isn't working spring cleaning Could be cleaned up one day
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Implement hidden fields bpmn-io/form-js
1 participant
@Skaiir