Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Radio group with dynamic values does not check initial value #1067

Closed
vsgoulart opened this issue Feb 21, 2024 · 1 comment · Fixed by #1068
Closed

Radio group with dynamic values does not check initial value #1067

vsgoulart opened this issue Feb 21, 2024 · 1 comment · Fixed by #1068
Assignees
Labels
bug Something isn't working

Comments

@vsgoulart
Copy link
Contributor

Describe the Bug

When populating a radio group via valuesExpression the initial value is not checked

Steps to Reproduce

  1. Render this form
  2. Try to initialize it with the payload below:
{
  "radio_field_options": [
    { "label": "Radio label", "value": "radio_value_1" },
    { "label": "Radio label 2", "value": "radio_value_2" }
  ],
  "radio_field": "radio_value_1"
}
  1. Radio label is not checked

Expected Behavior

Radio label should be checked

Environment

  • Library version: possibly since 1.5.0
@vsgoulart vsgoulart added the bug Something isn't working label Feb 21, 2024
@Skaiir Skaiir self-assigned this Feb 22, 2024
@Skaiir Skaiir added the ready Ready to be worked on label Feb 22, 2024
@Skaiir
Copy link
Contributor

Skaiir commented Feb 22, 2024

Issue here is that the sanitation code is using some old methods that haven't been updated to handle feel expressions. This probably isn't radio specific.

@bpmn-io-tasks bpmn-io-tasks bot added in progress Currently worked on and removed ready Ready to be worked on labels Feb 22, 2024
Skaiir added a commit that referenced this issue Feb 22, 2024
Skaiir added a commit that referenced this issue Feb 22, 2024
Skaiir added a commit that referenced this issue Feb 22, 2024
@bpmn-io-tasks bpmn-io-tasks bot added needs review Review pending and removed in progress Currently worked on labels Feb 22, 2024
Skaiir added a commit that referenced this issue Feb 23, 2024
Skaiir added a commit that referenced this issue Feb 23, 2024
@Skaiir Skaiir closed this as completed Feb 23, 2024
@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label Feb 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants