Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disabled should hide readonly property #1063

Closed
Skaiir opened this issue Feb 21, 2024 · 0 comments
Closed

Disabled should hide readonly property #1063

Skaiir opened this issue Feb 21, 2024 · 0 comments
Assignees
@Skaiir
Labels
bug Something isn't working

Comments

@Skaiir
Copy link
Contributor

Skaiir commented Feb 21, 2024

Describe the Bug

grafik

Disabled property takes precedence over readonly, so we should hide the options from the properties panel when we activate it, since it doesn't make sense to configure both.

Steps to Reproduce

  1. add a number field
  2. set disabled to true
  3. readonly option is still changable

Expected Behavior

  1. readonly options should be hidden
@Skaiir Skaiir added bug Something isn't working backlog Queued in backlog labels Feb 21, 2024
@Skaiir Skaiir self-assigned this Feb 21, 2024
@Skaiir Skaiir added ready Ready to be worked on and removed backlog Queued in backlog labels Feb 21, 2024
Skaiir added a commit that referenced this issue Feb 21, 2024
@Skaiir
fix: hide readonly option when disabled is active
db9c563 
Closes #1063
@bpmn-io-tasks bpmn-io-tasks bot added in progress Currently worked on and removed ready Ready to be worked on labels Feb 21, 2024
Skaiir added a commit that referenced this issue Feb 21, 2024
@Skaiir
fix: hide readonly option when disabled is active
e152d61 
Closes #1063
@Skaiir Skaiir mentioned this issue Feb 21, 2024
Merged
@bpmn-io-tasks bpmn-io-tasks bot added needs review Review pending and removed in progress Currently worked on labels Feb 21, 2024
Skaiir added a commit that referenced this issue Feb 22, 2024
@Skaiir
chore: added tests for read only property
e562855 
Related to #1063
Skaiir added a commit that referenced this issue Feb 22, 2024
@Skaiir
chore: added tests for read only property
06ff5fd 
Related to #1063
Skaiir added a commit that referenced this issue Feb 22, 2024
@Skaiir
fix: hide readonly option when disabled is active
e1def6b 
Closes #1063
Skaiir added a commit that referenced this issue Feb 22, 2024
@Skaiir
chore: added tests for read only property
6738227 
Related to #1063
@Skaiir Skaiir closed this as completed Feb 22, 2024
@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label Feb 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Skaiir Skaiir

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Skaiir