Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Links in HTML component always open in same view #1054

Closed
christian-konrad opened this issue Feb 16, 2024 · 6 comments
Closed

Bug: Links in HTML component always open in same view #1054

christian-konrad opened this issue Feb 16, 2024 · 6 comments
Assignees
Labels
bug Something isn't working

Comments

@christian-konrad
Copy link
Contributor

Describe the Bug

Links in the HTML component always open in the same view, even when target="_blank" is present.

Steps to Reproduce

  1. Add HTML view and add link with target="_blank"
  2. Deploy form to Tasklist (or test in forms playground)
  3. Clicking the link opens it in the same tab

Expected Behavior

Links should always open in a new tab

Environment

  • form-js 1.7
@christian-konrad christian-konrad added the bug Something isn't working label Feb 16, 2024
@Skaiir
Copy link
Contributor

Skaiir commented Feb 19, 2024

I'm fixing this directly in web modeler, as we don't really want to make assumptions within form-js about how those links should redirect. It's up to the implementer I reckon to choose.

https://github.com/camunda/web-modeler/pull/8211

@christian-konrad
Copy link
Contributor Author

@Skaiir makes sense, but also take care of Tasklist here, and it should not sanitize target="_blank" I believe

@Skaiir
Copy link
Contributor

Skaiir commented Feb 21, 2024

This has been updated in web modeler and merged. It still needs updating in tasklist.

@marcosgvieira
Copy link

@Skaiir can we move this one, was it updated on tasklist?

@christian-konrad christian-konrad changed the title Links in HTML component always open in same view Bug: Links in HTML component always open in same view Mar 4, 2024
@Skaiir Skaiir added the backlog Queued in backlog label Mar 5, 2024
@Skaiir
Copy link
Contributor

Skaiir commented Mar 5, 2024

Let's move it back to the backlog for now.

@Skaiir Skaiir added needs review Review pending and removed backlog Queued in backlog labels Mar 6, 2024
@Skaiir
Copy link
Contributor

Skaiir commented Mar 6, 2024

Actually we ended up fixing this in tasklist as well with the new release, so this issue may now be closed.

@Skaiir Skaiir closed this as completed Mar 6, 2024
@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants