Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Html component content isn't considered in getSchemaVariables #1047

Closed
Skaiir opened this issue Feb 15, 2024 · 0 comments · Fixed by #1048
Closed

Html component content isn't considered in getSchemaVariables #1047

Skaiir opened this issue Feb 15, 2024 · 0 comments · Fixed by #1048
Assignees
@Skaiir
Labels
bug Something isn't working

Comments

@Skaiir
Copy link
Contributor

Skaiir commented Feb 15, 2024

Describe the Bug

The variables inside of the HTML component content are not fetched due to the property not being whitelisted.

Steps to Reproduce

  1. Create a form with an HTML component only which has some variables
  2. Run getSchemaVariables on it -> no variables included

Expected Behavior

  1. yes variables includes
@Skaiir Skaiir added bug Something isn't working ready Ready to be worked on labels Feb 15, 2024
@Skaiir Skaiir self-assigned this Feb 15, 2024
Skaiir added a commit that referenced this issue Feb 15, 2024
@Skaiir
fix: ensure html content variables are included in getSchemaVariables
9ae49d6 
Closes #1047
@bpmn-io-tasks bpmn-io-tasks bot added in progress Currently worked on and removed ready Ready to be worked on labels Feb 15, 2024
@Skaiir Skaiir mentioned this issue Feb 15, 2024
Merged
@bpmn-io-tasks bpmn-io-tasks bot added needs review Review pending and removed in progress Currently worked on labels Feb 15, 2024
Skaiir added a commit that referenced this issue Feb 15, 2024
@Skaiir
fix: ensure html content variables are included in getSchemaVariables
6a19daa 
Closes #1047
@esraagamal6 esraagamal6 mentioned this issue Feb 15, 2024
Merged
@Skaiir Skaiir closed this as completed Feb 19, 2024
@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label Feb 19, 2024
vsgoulart pushed a commit that referenced this issue Feb 20, 2024
@Skaiir @vsgoulart
fix: ensure html content variables are included in getSchemaVariables
05c4e35 
Closes #1047
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Skaiir Skaiir

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: ensure html content variables are included in getSchemaVariables bpmn-io/form-js
1 participant
@Skaiir