Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simple select throws some errors due to unmounted ref #1045

Closed
Skaiir opened this issue Feb 15, 2024 · 0 comments
Closed

Simple select throws some errors due to unmounted ref #1045

Skaiir opened this issue Feb 15, 2024 · 0 comments
Assignees
Labels
bug Something isn't working

Comments

@Skaiir
Copy link
Contributor

Skaiir commented Feb 15, 2024

Describe the Bug

Following this change, sentry is picking up a few errors: Cannot read properties of undefined (reading 'focus' / 'blur')

This looks like it 's trying to call functions on the component when it isn't mounted.

After a bit more investigation, this is a full blown bug as the mousedown event is trying to access the dropdown even when the component is disabled, and hence not rendered.

Steps to Reproduce

  1. disable a simpleSelect
  2. click around on it
  3. an exception it thrown

Expected Behavior

  1. no exception should be thrown
@Skaiir Skaiir added bug Something isn't working ready Ready to be worked on labels Feb 15, 2024
@Skaiir Skaiir self-assigned this Feb 15, 2024
@bpmn-io-tasks bpmn-io-tasks bot added in progress Currently worked on and removed ready Ready to be worked on labels Feb 15, 2024
@bpmn-io-tasks bpmn-io-tasks bot added needs review Review pending and removed in progress Currently worked on labels Feb 15, 2024
@Skaiir Skaiir closed this as completed Feb 19, 2024
@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label Feb 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant