Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Form preview link sometimes breaks when the branch name cuts off on a dash #1015

Open
Skaiir opened this issue Jan 30, 2024 · 0 comments
Open
Labels
backlog Queued in backlog bug Something isn't working infrastructure spring cleaning Could be cleaned up one day

Comments

@Skaiir
Copy link
Contributor

Skaiir commented Jan 30, 2024

Describe the Bug

When linking a branch which is long enough and includes dashes (-), sometimes the playground link doesn't match the actual upload link.

Example for this PR: #999

Link in the PR points to:
https://demo-642-relax-text-component---camunda-form-playground.netlify.app/

But it's actually uploaded at:
https://demo-642-relax-text-component--camunda-form-playground.netlify.app/

There's an extra dash that snuck in there (or was lost).

Fun bug.

Steps to Reproduce

Haven't reproduced yet, lazy. But I assume this will break if you:

  1. create a PR from a branch named after the pattern any 24 characters - anything
  2. add deploy-preview on the PR
  3. let it build
  4. navigate to it
  5. dead link
  6. remove one of the dashes from the url
  7. proper link

Expected Behavior

  1. the link posted to github should be the proper one
@Skaiir Skaiir added bug Something isn't working backlog Queued in backlog spring cleaning Could be cleaned up one day technical debt infrastructure and removed technical debt labels Jan 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backlog Queued in backlog bug Something isn't working infrastructure spring cleaning Could be cleaned up one day
Projects
None yet
Development

No branches or pull requests

1 participant