Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A bug occurs when deleting a box :A DOM element reference is required, But there is no problem using shift to select #2221

Open
nanfb opened this issue Aug 19, 2024 · 7 comments
Labels
backlog Queued in backlog bug Something isn't working good first issue Good for newcomers spring cleaning Could be cleaned up one day

Comments

@nanfb
Copy link

nanfb commented Aug 19, 2024

Describe the Bug

I don't know if this is a feature: shift+left mouse button to select the element dragged into the canvas, and then use the shortcut key del to delete, a bug will appear: console.ts:40 unhandled error in event listener Error: A DOM element reference is required, But there is no problem using shift to select

Steps to Reproduce

Shift+left mouse button selects the elements dragged into the canvas, and then uses the shortcut key del to delete shift+left mouse button to select the elements dragged into the canvas, and then uses the shortcut key del to delete

The following cases occurred in:https://demo.bpmn.io/s/start

exmpper.mp4

Expected Behavior

Delete the node selected by the box

Environment

  • Browser: [Chrome 127.0.6533.120]
  • OS: [e.g. Windows 11]
@nanfb nanfb added the bug Something isn't working label Aug 19, 2024
@barmac
Copy link
Member

barmac commented Aug 19, 2024

I can reproduce this issue. Thanks for reporting.

@barmac barmac added ready Ready to be worked on good first issue Good for newcomers spring cleaning Could be cleaned up one day labels Aug 19, 2024
@nikku
Copy link
Member

nikku commented Aug 19, 2024

@barmac I cannot reproduce it locally. Could we try to get https://github.com/bpmn-io/bpmn-io-demo/pull/184 merged and see if we can still reproduce?

@barmac
Copy link
Member

barmac commented Aug 19, 2024

I cannot reproduce the issue with the PR you shared!

@barmac
Copy link
Member

barmac commented Aug 19, 2024

I can reproduce it on main though.

Screen.Recording.2024-08-19.at.15.33.28.mov

@barmac
Copy link
Member

barmac commented Aug 19, 2024

Note that you need to keep pressing shift when you add the second shape, and select the same shape with shift pressed again.

@nanfb
Copy link
Author

nanfb commented Aug 20, 2024

@barmac我无法在本地重现它。我们可以尝试合并https://github.com/bpmn-io/bpmn-io-demo/pull/184并查看是否仍可以重现吗?
Simple multi-selection is normal. The key point is box selection, which is to hold down shift and use the left mouse button to select nodes and then delete them.

@barmac barmac added backlog Queued in backlog and removed ready Ready to be worked on labels Aug 27, 2024
@barmac
Copy link
Member

barmac commented Aug 27, 2024

@nikku to add it to the spring cleaning list.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backlog Queued in backlog bug Something isn't working good first issue Good for newcomers spring cleaning Could be cleaned up one day
Projects
None yet
Development

No branches or pull requests

3 participants