Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add create to palette #1798

Closed
2 tasks
Tracked by #1627
smbea opened this issue Jan 5, 2023 · 3 comments · Fixed by #1811
Closed
2 tasks
Tracked by #1627

Add create to palette #1798

smbea opened this issue Jan 5, 2023 · 3 comments · Fixed by #1811
Assignees

Comments

@smbea
Copy link
Contributor

smbea commented Jan 5, 2023

What should we do?

Add a "create anything" entry to the palette which provides a menu with all possible elements.

What it should look like (but with bpmn elements):
Screenshot 2023-01-10 at 16 38 45

To do:

  • Add entry to palette
  • Add create menu entries provider

Why should we do it?

To support create anything, see #1627

@smbea smbea changed the title [bpmn-js] Add create to palette Add create to palette Jan 5, 2023
@smbea smbea self-assigned this Jan 5, 2023
@smbea smbea added the ready Ready to be worked on label Jan 5, 2023
@smbea
Copy link
Contributor Author

smbea commented Jan 19, 2023

When initially creating an empty pool, it is "casted" into an expanded pool. This makes sense generally. But (edge case) does it make sense if the canvas is empty?

Screen.Recording.2023-01-19.at.12.19.59.mov

We may want to leave it for now because it's not a usual sequence users take (i am assuming), but this could be tackled via CreateParticipantBehavior, in a way that it only happens if there are some elements on the canvas. I've tried this:

Screen.Recording.2023-01-19.at.12.18.30.mov

cc @nikku

@nikku
Copy link
Member

nikku commented Jan 19, 2023

But (edge case) does it make sense if the canvas is empty?

I think it does, because a diagram must always contain at least one process, and that is the one wrapped in the pool. We'd otherwise end up with empty pools in process diagrams (not containing expanded participants). We don't support such things yet.

smbea added a commit that referenced this issue Jan 19, 2023
@bpmn-io-tasks bpmn-io-tasks bot added in progress Currently worked on and removed ready Ready to be worked on labels Jan 19, 2023
smbea added a commit that referenced this issue Jan 19, 2023
smbea added a commit that referenced this issue Jan 19, 2023
@bpmn-io-tasks bpmn-io-tasks bot added needs review Review pending and removed in progress Currently worked on labels Jan 19, 2023
@barmac
Copy link
Member

barmac commented Jan 19, 2023

An empty pool in a process diagram is a complex topic which we have not figured out yet. BPMN allows to have a collaboration diagram where one main process is not enclosed in a pool (participant), but there are no properties in the spec which would tell which process is the main one.

smbea added a commit that referenced this issue Jan 23, 2023
smbea added a commit that referenced this issue Jan 23, 2023
smbea added a commit that referenced this issue Jan 23, 2023
smbea added a commit that referenced this issue Jan 23, 2023
smbea added a commit that referenced this issue Jan 23, 2023
smbea added a commit that referenced this issue Jan 23, 2023
@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label Jan 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants