Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Module Can Make Undo Impossible #3

Closed
philippfromme opened this issue Jan 21, 2021 · 1 comment
Closed

Module Can Make Undo Impossible #3

philippfromme opened this issue Jan 21, 2021 · 1 comment
Labels
bug Something isn't working wontfix This will not be worked on

Comments

@philippfromme
Copy link
Contributor

Using the module with alignOnSave = true can make undo impossible. When a user wants to save on commandStack.changed he won't be able to undo in some cases.

You can reproduce the issue using this CodeSandbox: https://codesandbox.io/s/undo-bug-o8v0q

  1. Delete the start event
  2. Click Undo
  3. Nothing happens 😢
@philippfromme philippfromme added the bug Something isn't working label Jan 21, 2021
@nikku nikku added backlog Queued in backlog and removed backlog Queued in backlog labels Jan 24, 2021 — with bpmn-io-tasks
@pinussilvestrus pinussilvestrus added the backlog Queued in backlog label Jan 28, 2021
@nikku nikku added ready Ready to be worked on and removed backlog Queued in backlog labels Feb 11, 2021 — with bpmn-io-tasks
@nikku
Copy link
Member

nikku commented Feb 27, 2021

Closing this issue for the reason described in #2 (comment).

To sum it up, this module is not compatible with commandStack.changed intercepting autoSave behaviors.

@nikku nikku added the wontfix This will not be worked on label Feb 27, 2021
@nikku nikku closed this as completed Feb 27, 2021
@bpmn-io-tasks bpmn-io-tasks bot removed the ready Ready to be worked on label Feb 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

3 participants