address comments

Signed-off-by: bowenlan-amzn <[email protected]>
bowenlan-amzn · Jan 3, 2024 · 480eb71 · 480eb71
1 parent 6e369b9
commit 480eb71
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 2 deletions.
diff --git a/server/src/main/java/org/opensearch/search/aggregations/bucket/FastFilterRewriteHelper.java b/server/src/main/java/org/opensearch/search/aggregations/bucket/FastFilterRewriteHelper.java
@@ -41,7 +41,7 @@
  * <p>
  * Currently supported rewrite:
  * <ul>
- *  <li> date histogram -> date range filter.
+ *  <li> date histogram : date range filter.
  *   Applied: DateHistogramAggregator, AutoDateHistogramAggregator, CompositeAggregator </li>
  * </ul>
  * @opensearch.internal

diff --git a/...rc/main/java/org/opensearch/search/aggregations/bucket/composite/CompositeAggregator.java b/...rc/main/java/org/opensearch/search/aggregations/bucket/composite/CompositeAggregator.java
@@ -249,7 +249,7 @@ public InternalAggregation[] buildAggregations(long[] owningBucketOrds) throws I
 
         // Build results from fast filters optimization
         if (bucketOrds != null) {
-            Map<CompositeKey, InternalComposite.InternalBucket> bucketMap = new HashMap<>();
+            final Map<CompositeKey, InternalComposite.InternalBucket> bucketMap = new HashMap<>();
             for (InternalComposite.InternalBucket internalBucket : buckets) {
                 bucketMap.put(internalBucket.getRawKey(), internalBucket);
             }

diff --git a/...c/main/java/org/opensearch/search/aggregations/bucket/composite/RoundingValuesSource.java b/...c/main/java/org/opensearch/search/aggregations/bucket/composite/RoundingValuesSource.java
@@ -55,6 +55,7 @@ class RoundingValuesSource extends ValuesSource.Numeric {
     /**
      * @param vs               The original values source
      * @param preparedRounding How to round the values
+     * @param rounding         The rounding strategy
      */
     RoundingValuesSource(Numeric vs, Rounding.Prepared preparedRounding, Rounding rounding) {
         this.vs = vs;