More changes #33
Merged
More changes #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It seems in previous numpy versions the index was allowed to be of type float. This is not the case anymore and we need to explicitly cast to int.
Float has only a limited accuracy, and this can lead to ind being n in some cases. Doing the module later in integer space avoids this issue, although theoretically an overflow could happen. However, in that case the accuracy is probably very poor.
They are, sorted fastes to slow: * _fast: extremly fast, but works only for sufficiently circular shapes * _convex_hull: still very fast, but can fail on beans, if the bean is very thin. Requires shapely * _alphashape: reasonably fast. So far worked for all tested cases. Should be much faster then lines_from_points(). Requires shapely and alphashape * _two_opt: Should find very good solutions, but is very slow. Mostly here so that I do not add it again, because I forgot that it is very slow.
Mostly for generating plots for a paper. It should probably not be used in practice ...
J is likely (a bit) wrong, as it misses the By/Bxyz correction for g22
Use smooth volumes, based on the curvilinear grid. This should improve agreement of the volumes with the normal interpretation of the cells, and thus improve confinement in the normal interpretation.
Replaced geqdsk file with one from freeqdsk
Not sure when this changed exactly
Used wrong number of indices to rzcoord array returned by trace_poincare. Now saves 3D metrics rather than 2D.
g22 was constant, but should have been a function of R Using a different magnetic field fixes this
bendudson
approved these changes
Nov 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.