Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testing refine methods #32

Open
johnomotani opened this issue Apr 29, 2020 · 1 comment
Open

Testing refine methods #32

johnomotani opened this issue Apr 29, 2020 · 1 comment

Comments

@johnomotani
Copy link
Collaborator

There are now several methods for refining points: line, newton, integrate, integrate+newton.
Only line is tested in test_equilbrium.py, and using other methods sometimes fails where line passes. I suspect this is because the tests start with points very far from the contour, and were set up in such a way that line would find the right contour, so this does not indicate a problem with the other methods. The failure of integrate may just be a question of slightly too tight tolerance (only fails test_refine), and integrate+newton fails to converge, but only on the same test. newton fails to converge on several tests.

@bendudson
Copy link
Contributor

This is tricky... there are cases when any (or all?) of these methods may fail. Newton in particular is either great or terrible depending on how close to the solution you start. We could use a simple test case where they all should pass, but a proper test (rather than a sanity check) is probably hard to design.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants