Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

futures.TransferCoordinator: fix cancellation deadlock #179

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

tschoonj
Copy link

@tschoonj tschoonj commented Mar 8, 2021

This patches fixes a deadlock whenever TransferManager._shutdown is
called with cancel==True

This patches fixes a deadlock whenever TransferManager._shutdown is
called with cancel==True
@codecov-io
Copy link

codecov-io commented Mar 9, 2021

Codecov Report

Merging #179 (3da31a7) into develop (e862f6b) will decrease coverage by 0.08%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #179      +/-   ##
===========================================
- Coverage    97.79%   97.71%   -0.09%     
===========================================
  Files           15       15              
  Lines         2408     2404       -4     
===========================================
- Hits          2355     2349       -6     
- Misses          53       55       +2     
Impacted Files Coverage Δ
s3transfer/futures.py 95.05% <100.00%> (-0.08%) ⬇️
s3transfer/manager.py 97.53% <0.00%> (-0.99%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e862f6b...3da31a7. Read the comment docs.

@tschoonj
Copy link
Author

@kdaily could you give this one a look? And #144?

Thanks in advance!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants