Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AnnotationConsolidationLambdaArn is not required #3278

Closed
BeRT2me opened this issue Oct 14, 2024 · 5 comments
Closed

AnnotationConsolidationLambdaArn is not required #3278

BeRT2me opened this issue Oct 14, 2024 · 5 comments
Assignees
Labels
bug This issue is a confirmed bug. documentation This is a problem with documentation. p3 This is a minor priority issue service-api This issue is caused by the service API, not the SDK implementation.

Comments

@BeRT2me
Copy link

BeRT2me commented Oct 14, 2024

Describe the issue

This parameter is required for all labeling jobs.

This is no longer true since AnnotationConsolidationConfig is no longer a required parameter.

This specific phrase should be removed.

Links

https://github.com/boto/botocore/blob/131f207c848663997e95f6490617d3642b37c662/botocore/data/sagemaker/2017-07-24/service-2.json#L4640

@BeRT2me BeRT2me added documentation This is a problem with documentation. needs-triage This issue or PR still needs to be triaged. labels Oct 14, 2024
@tim-finnigan tim-finnigan self-assigned this Oct 15, 2024
@tim-finnigan tim-finnigan added the investigating This issue is being investigated and/or work is in progress to resolve the issue. label Oct 15, 2024
@tim-finnigan
Copy link
Contributor

Thanks for reaching out. Looking at the Amazon SageMaker docs for the AnnotationConsolidationConfig API, it says for Required: Yes for AnnotationConsolidationLambdaArn towards the bottom of the page. So I'd think we'd have to confirm with the SageMaker team what updates would be required here. Are you running create_labeling_job or another SageMaker command? If you can share a snippet or any more details on your use case please let us know.

@tim-finnigan tim-finnigan added response-requested Waiting on additional info and feedback. p2 This is a standard priority issue service-api This issue is caused by the service API, not the SDK implementation. and removed investigating This issue is being investigated and/or work is in progress to resolve the issue. needs-triage This issue or PR still needs to be triaged. labels Oct 15, 2024
@BeRT2me
Copy link
Author

BeRT2me commented Oct 16, 2024

AnnotationConsolidationLambdaArn is required only if AnnotationConsolidationConfig is provided.

AnnotationConsolidationConfig itself is no longer required API_HumanTaskConfig

Therefore, it is incorrect to say that AnnotationConsolidationLambdaArn is required for all labeling jobs. It is now only required for labeling jobs that request Annotation Consolidation.

@github-actions github-actions bot removed the response-requested Waiting on additional info and feedback. label Oct 16, 2024
@tim-finnigan
Copy link
Contributor

Thanks for following up and clarifying that. I'll reach out to the SageMaker documentation team about updating the wording, and any updates to the API documentation should be reflected downstream in SDK documentation.

@tim-finnigan tim-finnigan added bug This issue is a confirmed bug. p3 This is a minor priority issue and removed p2 This is a standard priority issue labels Oct 16, 2024
@tim-finnigan tim-finnigan removed their assignment Oct 16, 2024
@tim-finnigan
Copy link
Contributor

We got confirmation from the SageMaker team that that was removed from the documentation. I confirmed that "This parameter is required for all labeling jobs." was removed from the service model. Thanks again for reporting this issue.

@tim-finnigan tim-finnigan self-assigned this Nov 1, 2024
Copy link

github-actions bot commented Nov 1, 2024

This issue is now closed. Comments on closed issues are hard for our team to see.
If you need more assistance, please open a new issue that references this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue is a confirmed bug. documentation This is a problem with documentation. p3 This is a minor priority issue service-api This issue is caused by the service API, not the SDK implementation.
Projects
None yet
Development

No branches or pull requests

2 participants