Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow using urllib3 2.1.x with Python 3.10+ #3065

Closed
1 of 2 tasks
iherasymenko opened this issue Nov 16, 2023 · 2 comments
Closed
1 of 2 tasks

Allow using urllib3 2.1.x with Python 3.10+ #3065

iherasymenko opened this issue Nov 16, 2023 · 2 comments
Assignees
@RyanFitzSimmonsAK
Labels
dependencies This issue is a problem in a dependency. duplicate This issue is a duplicate. feature-request This issue requests a feature. p2 This is a standard priority issue

Comments

@iherasymenko
Copy link

Describe the feature

This commit relaxed the version constraint and now it is possible to use botocore with urllib3 versions 2.0.x; however, this does not allow using botocore with urllib3 2.1.x.

Use Case

I want to keep all of my dependencies up-to-date.

Proposed Solution

Change the constraint from urllib3>=1.25.4,<2.1; python_version>="3.10" to urllib3>=1.25.4,<3; python_version>="3.10"

Other Information

No response

Acknowledgements

  • I may be able to implement this feature request
  • This feature might incur a breaking change

SDK version used

1.29.1

Environment details (OS name and version, etc.)

N/A
@iherasymenko iherasymenko added feature-request This issue requests a feature. needs-triage This issue or PR still needs to be triaged. labels Nov 16, 2023
@RyanFitzSimmonsAK RyanFitzSimmonsAK self-assigned this Nov 16, 2023
@RyanFitzSimmonsAK RyanFitzSimmonsAK added dependencies This issue is a problem in a dependency. duplicate This issue is a duplicate. p2 This is a standard priority issue and removed needs-triage This issue or PR still needs to be triaged. labels Nov 16, 2023
@RyanFitzSimmonsAK
Copy link
Contributor

Hi @iherasymenko, thanks for reaching out. According to the main tracking thread for the urllib3 pin, urllib3 2.1.x contains several breaking changes.

#2926 (comment)

We're currently pinned at urllib3<2.1 since it will contain a handful of breaking changes.

I'm going to close this issue as a duplicate in favor of the main tracking thread, which you can refer to for any updates regarding the urllib3 pin.

@RyanFitzSimmonsAK RyanFitzSimmonsAK closed this as not planned Won't fix, can't repro, duplicate, stale Nov 16, 2023
@github-actions GitHub Actions
Copy link

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

lunika added a commit to openfun/marsha that referenced this issue Nov 27, 2023
@lunika
📌(back) ping urllib3 to version 2.0.7
9000b7f 
Botocore is still not compatible with urllib3 version 2.1.0
The version 2.1.0 of urllib3 may contains several BC according to this
issue : boto/botocore#3065
lunika added a commit to openfun/marsha that referenced this issue Nov 28, 2023
@lunika
📌(back) pin urllib3 to version 2.0.7
1b32d91 
Botocore is still not compatible with urllib3 version 2.1.0
The version 2.1.0 of urllib3 may contains several BC according to this
issue : boto/botocore#3065
lunika added a commit to openfun/marsha that referenced this issue Nov 28, 2023
@lunika
📌(back) pin urllib3 to version 2.0.7
1882595 
Botocore is still not compatible with urllib3 version 2.1.0
The version 2.1.0 of urllib3 may contains several BC according to this
issue : boto/botocore#3065
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@RyanFitzSimmonsAK RyanFitzSimmonsAK

Labels
dependencies This issue is a problem in a dependency. duplicate This issue is a duplicate. feature-request This issue requests a feature. p2 This is a standard priority issue
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@iherasymenko @RyanFitzSimmonsAK