Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add waiter for ControlTower Baseline Operation #4036

Closed
2 tasks
kclinden opened this issue Feb 27, 2024 · 5 comments
Closed
2 tasks

Add waiter for ControlTower Baseline Operation #4036

kclinden opened this issue Feb 27, 2024 · 5 comments
Assignees
Labels
closed-for-staleness feature-request This issue requests a feature. p3 This is a minor priority issue response-requested Waiting on additional information or feedback.

Comments

@kclinden
Copy link

Describe the feature

Enabling a baseline in control tower needs to wait for baselines to be status SUCCEEDED. Setup a waiter for this so that it doesn't have to be done manually.

Use Case

enabling baselines for several OUs in control tower

def wait_for_baseline_operation(operation_id, region):
    ct_client = boto3.client('controltower', region_name=region)
    try:
        waiter = ct_client.get_waiter('baseline_operation_complete')
        waiter.wait(
            BaselineId='arn:aws:controltower:'+region+'::baseline/17BSJV3IGJ2QSGA2',
            OperationId=operation_id
        )

Proposed Solution

No response

Other Information

No response

Acknowledgements

  • I may be able to implement this feature request
  • This feature might incur a breaking change

SDK version used

1.34.50

Environment details (OS name and version, etc.)

macOS 14.3.1 (23D60)

@kclinden kclinden added feature-request This issue requests a feature. needs-triage This issue or PR still needs to be triaged. labels Feb 27, 2024
@RyanFitzSimmonsAK RyanFitzSimmonsAK self-assigned this Mar 12, 2024
@RyanFitzSimmonsAK RyanFitzSimmonsAK added p3 This is a minor priority issue and removed needs-triage This issue or PR still needs to be triaged. labels Mar 12, 2024
@RyanFitzSimmonsAK
Copy link
Contributor

HI @kclinden, thanks for this feature request. To clarify the ask, you'd like a Waiter that waits on the status of an Baseline resource to be SUCCEEDED? If that's correct, I can forward this feedback to the Control Tower team. Otherwise, please correct me.

@RyanFitzSimmonsAK RyanFitzSimmonsAK added the response-requested Waiting on additional information or feedback. label Mar 12, 2024
Copy link

Greetings! It looks like this issue hasn’t been active in longer than five days. We encourage you to check if this is still an issue in the latest release. In the absence of more information, we will be closing this issue soon. If you find that this is still a problem, please feel free to provide a comment or upvote with a reaction on the initial post to prevent automatic closure. If the issue is already closed, please feel free to open a new one.

@github-actions github-actions bot added closing-soon This issue will automatically close in 4 days unless further comments are made. closed-for-staleness and removed closing-soon This issue will automatically close in 4 days unless further comments are made. labels Mar 23, 2024
@kclinden
Copy link
Author

Didn’t get the message! Yes that is correct

@kclinden
Copy link
Author

HI @kclinden, thanks for this feature request. To clarify the ask, you'd like a Waiter that waits on the status of an Baseline resource to be SUCCEEDED? If that's correct, I can forward this feedback to the Control Tower team. Otherwise, please correct me.

Can we reopen this?

Copy link

This issue is now closed. Comments on closed issues are hard for our team to see.
If you need more assistance, please open a new issue that references this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
closed-for-staleness feature-request This issue requests a feature. p3 This is a minor priority issue response-requested Waiting on additional information or feedback.
Projects
None yet
Development

No branches or pull requests

2 participants