Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

association.gateway-id filter parameter is missing in https://boto3.amazonaws.com/v1/documentation/api/latest/reference/services/ec2/client/describe_route_tables.html #3974

Closed
Yatin03 opened this issue Dec 18, 2023 · 5 comments
Assignees
Labels
documentation This is a problem with documentation. ec2 p3 This is a minor priority issue response-requested Waiting on additional information or feedback.

Comments

@Yatin03
Copy link

Yatin03 commented Dec 18, 2023

Describe the issue

association.gateway-id filter parameter is missing in https://boto3.amazonaws.com/v1/documentation/api/latest/reference/services/ec2/client/describe_route_tables.html.

Links

https://boto3.amazonaws.com/v1/documentation/api/latest/reference/services/ec2/client/describe_route_tables.html

@Yatin03 Yatin03 added documentation This is a problem with documentation. needs-triage This issue or PR still needs to be triaged. labels Dec 18, 2023
@Yatin03
Copy link
Author

Yatin03 commented Dec 18, 2023

I would like to know where I can make changes and raise a pull request.

@RyanFitzSimmonsAK RyanFitzSimmonsAK self-assigned this Dec 18, 2023
@RyanFitzSimmonsAK RyanFitzSimmonsAK added investigating This issue is being investigated and/or work is in progress to resolve the issue. ec2 p3 This is a minor priority issue and removed needs-triage This issue or PR still needs to be triaged. labels Dec 18, 2023
@RyanFitzSimmonsAK
Copy link
Contributor

Hi @Yatin03, thanks for reaching out. I'm not seeing association.gateway-id as an available filter for this operation in the API reference guide. Are route.nat-gateway-id or route.transit-gateway-id not what you're looking for?. If another SDK does support filtering on association.gateway-id, please point me towards it. If not, I can forward this to the service team as a feature request.

On the topic of contributing to the repository, I'd recommend reading the contribution guide. However, because filter parameters are provided by the service team, you won't be able to make this particular change happen through a pull request.

Hope that helps!

@RyanFitzSimmonsAK RyanFitzSimmonsAK added response-requested Waiting on additional information or feedback. and removed investigating This issue is being investigated and/or work is in progress to resolve the issue. labels Dec 19, 2023
@Yatin03
Copy link
Author

Yatin03 commented Dec 20, 2023

Hi @RyanFitzSimmonsAK,

association.gateway-id filter is supported but not documented. So, i want to add in document.
Sample Code:
`import boto3

ec2 = boto3.resource('ec2')
client = boto3.client('ec2')

response = client.describe_route_tables(
Filters=[
{
'Name': 'association.gateway-id',
'Values': ["igw-****"]
}
]
)

print(json.dumps(response, indent=2))

print(response["RouteTables"][0]["RouteTableId"])`

@RyanFitzSimmonsAK
Copy link
Contributor

Thanks for clarifying, I was able to reproduce this. As this is a service team issue, I've reached out to the EC2 team about making this change to the documentation. In the meantime, I'm going to create a tracking issue in our cross-SDK repository (aws/aws-sdk#666). I'll leave any updates in the new issue. Thanks!

Copy link

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation This is a problem with documentation. ec2 p3 This is a minor priority issue response-requested Waiting on additional information or feedback.
Projects
None yet
Development

No branches or pull requests

2 participants