Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lakeformation list_permission does not implement a paginator #3932

Closed
theister opened this issue Nov 14, 2023 · 2 comments
Closed

Lakeformation list_permission does not implement a paginator #3932

theister opened this issue Nov 14, 2023 · 2 comments
Assignees
Labels
bug This issue is a confirmed bug. investigating This issue is being investigated and/or work is in progress to resolve the issue. lakeformation p2 This is a standard priority issue pagination

Comments

@theister
Copy link

theister commented Nov 14, 2023

Describe the bug

lakeformation / list-permissions is a paginated API call that uses the standard pagination api using MaxResults & NextToken.

Unlike other methods of the lakeformation client, it is not possible to call it using a boto3 paginator, which makes writing code around that api call a pain that requires a lot of boilerplate as a workaround.

Expected Behavior

The method returns a paginator.

Current Behavior

Boto returns the error/stacktrace:

  File ".../python-3.11/lib/python3.11/site-packages/botocore/client.py", line 1121, in get_paginator
    raise OperationNotPageableError(operation_name=operation_name)

botocore.exceptions.OperationNotPageableError: Operation cannot be paginated: list_permissions

Reproduction Steps

(within a valid aws session)

import boto3
lf_client = boto3.client("lakeformation")
paginator = lf_client.get_paginator("list_permissions")

Possible Solution

Implement a boto paginator for all lakeformation api calls that need to be called paginated.

Additional Information/Context

No response

SDK version used

boto3==1.28.82 botocore==1.31.82

Environment details (OS name and version, etc.)

python 3.11.5

@theister theister added bug This issue is a confirmed bug. needs-triage This issue or PR still needs to be triaged. labels Nov 14, 2023
@RyanFitzSimmonsAK RyanFitzSimmonsAK self-assigned this Nov 14, 2023
@RyanFitzSimmonsAK RyanFitzSimmonsAK added investigating This issue is being investigated and/or work is in progress to resolve the issue. pagination lakeformation p2 This is a standard priority issue and removed needs-triage This issue or PR still needs to be triaged. labels Nov 14, 2023
@RyanFitzSimmonsAK
Copy link
Contributor

RyanFitzSimmonsAK commented Nov 14, 2023

Hi @theister, thanks for reaching out. It looks like there is an issue with the model file that affects a couple Lake Formation operations. I've reached out to the service team regarding this. In the meantime, as this is an issue relevant to several SDKs, I'm going to close this issue and create a new one in our cross-SDK repository (aws/aws-sdk#643). Please refer to that issue for any updates. Thanks!

Copy link

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue is a confirmed bug. investigating This issue is being investigated and/or work is in progress to resolve the issue. lakeformation p2 This is a standard priority issue pagination
Projects
None yet
Development

No branches or pull requests

2 participants