-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SQS example VisibilityTimeout value too low #3652
Comments
Hi @HJTP, thanks for reaching out. I spoke to someone on the team, and they pointed out that 0 is a valid value for that field, and that the example isn't intended to work off-the-shelf. I think an improvement that would help more people would be adding the details about |
Hi @RyanFitzSimmonsAK , thanks for the reply! Firstly, I must add that my comment only applies for FIFO queues. For normal queues, the example code might work (I have not tested this). Regarding your proposal: good idea! Is there some kind of "important note" type of text block we could use for this caveat? |
Yep, an example of an important note can be found on this page. This note basically contains all the information we need, so it's just a matter of adding it to the boto3 docs. |
@RyanFitzSimmonsAK OK! Do I do that or you? |
That's something for me to bring up internally, which I've already done. Thanks again for raising this issue, I'll update you here once some progress has been made! |
You're welcome! While you're at it, I just found another one. While valid values are 1-10. Not a big deal, but might as well use a valid value as the example, right? |
The Boto3 SQS user guide links to the SQS developer guide, which discussed the consequences of setting
Closing this issue. |
This issue is now closed. Comments on closed issues are hard for our team to see. |
Describe the issue
On this SQS example page:
https://boto3.amazonaws.com/v1/documentation/api/latest/guide/sqs-example-sending-receiving-msgs.html
The
VisibilityTimeout
for the receive-and-delete example is set to 0. However, a message must be deleted within its visibility window. If the window is set to 0, it must be deleted within the same millisecond, as per the AWS docs. This code cannot reliably achieve this. Therefore, I'd propose setting theVisibilityTimeout
to a value like 5 seconds:VisibilityTimeout=5,
Links
https://boto3.amazonaws.com/v1/documentation/api/latest/guide/sqs-example-sending-receiving-msgs.html
The text was updated successfully, but these errors were encountered: