anyone know why codecommit get_comments_for_pull_request return empty?

[ramunecroft]

def get_pull_requests(client: CodeCommitClient, repository_name: str):
    return client.list_pull_requests(repositoryName=repository_name)

prResponse = get_pull_requests(client, 'aaaa')

pullRequestIds: List[str] = prResponse.get('pullRequestIds', [])


for prId in pullRequestIds:
    prDetails = client.get_pull_request(pullRequestId=prId)
    prAuthor = prDetails.get("pullRequest").get("authorArn")
    target = prDetails.get("pullRequest").get("pullRequestTargets")
    if target:
        destinationCommitId = target[0].get("destinationCommit") or ""
        sourceCommitId = target[0].get("sourceCommit") or ""
        
        res = client.get_comments_for_pull_request(pullRequestId=prId,repositoryName="aaaa",  beforeCommitId=destinationCommitId, afterCommitId=sourceCommitId)
        print(res)

i'm trying to get pr comments on codecommit

i'm sure destinationId is latest commit on target branch and
sourceCommitId is latest commit on pr.
i'm using root credentials

status is absolutely 200

I originally tried with go sdk, but empty came back so I'm trying with python...

idk why result is empty

[ramunecroft]

Umm..i fixed it by client.get_comments_for_pull_request(pullRequestId=prId,repositoryName="aaaa", beforeCommitId=destinationCommitId, afterCommitId=sourceCommitId) -> client.get_comments_for_pull_request(pullRequestId=prId)

[github-actions[bot]]

Hello! Reopening this discussion to make it searchable.