Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Relay Dockerfile #102

Merged
merged 1 commit into from
Aug 28, 2023
Merged

Add Relay Dockerfile #102

merged 1 commit into from
Aug 28, 2023

Conversation

TrustHenry
Copy link
Member

No description provided.

Copy link
Collaborator

@Kang-Simon Kang-Simon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TrustHenry TrustHenry added this to the DApp milestone Aug 25, 2023
@TrustHenry TrustHenry linked an issue Aug 25, 2023 that may be closed by this pull request
Copy link
Member

@MichaelKim20 MichaelKim20 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. dms-chain에 추가된 docker-compose.yml에는 환경변수 RPC_URL가 사용되었습니다. 그기에 맞게 이곳의 DEV_NET_URL를 RPC_URL로 변경해 주세요
  2. config.yaml에서 manager_key를 등록하기 위해서 사용된 환경변수 MANAGER를 설정한 부분이 없습니다.
    MANAGER_KEY로 변경해주시고요 이값은 아래 값을 사용해주세요
    {
    "address": "0x454cd944C9Eac1e84064c0D105931aDCEbC86c89",
    "privateKey": "0xf17b5048d0acdcabcc1fa5f3e1aa6753243d4309a6a30f951d5712cb50c86671"
    },

packages/relay/env/.env.sample Outdated Show resolved Hide resolved
packages/relay/hardhat.config.ts Outdated Show resolved Hide resolved
Copy link
Member

@MichaelKim20 MichaelKim20 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

MANAGER 로 된 코드가 하나더 있네요

) {
accounts.push(process.env.MANAGER);
accounts.push(process.env.MANAGER_KEY);
} else {
process.env.MANAGER = Wallet.createRandom().privateKey;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
process.env.MANAGER = Wallet.createRandom().privateKey;
process.env.MANAGER_KEY = Wallet.createRandom().privateKey;

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx, Nice catch!

@TrustHenry TrustHenry merged commit 58d91ec into bosagora:v0.x.x Aug 28, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

[릴레이RPC] 도커이미지를 제공한다.
3 participants