-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Relay Dockerfile #102
Add Relay Dockerfile #102
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- dms-chain에 추가된 docker-compose.yml에는 환경변수 RPC_URL가 사용되었습니다. 그기에 맞게 이곳의 DEV_NET_URL를 RPC_URL로 변경해 주세요
- config.yaml에서 manager_key를 등록하기 위해서 사용된 환경변수 MANAGER를 설정한 부분이 없습니다.
MANAGER_KEY로 변경해주시고요 이값은 아래 값을 사용해주세요
{
"address": "0x454cd944C9Eac1e84064c0D105931aDCEbC86c89",
"privateKey": "0xf17b5048d0acdcabcc1fa5f3e1aa6753243d4309a6a30f951d5712cb50c86671"
},
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
MANAGER 로 된 코드가 하나더 있네요
packages/relay/hardhat.config.ts
Outdated
) { | ||
accounts.push(process.env.MANAGER); | ||
accounts.push(process.env.MANAGER_KEY); | ||
} else { | ||
process.env.MANAGER = Wallet.createRandom().privateKey; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
process.env.MANAGER = Wallet.createRandom().privateKey; | |
process.env.MANAGER_KEY = Wallet.createRandom().privateKey; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thx, Nice catch!
No description provided.