Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Loading order of hyperref and hyperxmp should be reversed #510

Open
iincer opened this issue Oct 14, 2023 · 1 comment
Open

Loading order of hyperref and hyperxmp should be reversed #510

iincer opened this issue Oct 14, 2023 · 1 comment

Comments

@iincer
Copy link

iincer commented Oct 14, 2023

Summary

The current version of acmart raises an error saying that hyperxml must be loaded before hyperxmp.

Reason

hyperxmp v5.12 (released on 9/10/23) introduced the following requirement:

New in v5.12 hyperref must be loaded before hyperxmp.
This is because recent changes in hyperref and the LATEX
kernel prevent hyperxmp from hooking into hyperref’s internals
if hyperref is loaded first.

The following code shows how acmart loads hyperref and hyperxmp:

acmart/acmart.dtx

Lines 3474 to 3489 in ec4b7b0

\RequirePackage{hyperxmp}
% \end{macrocode}
%
%
% And now, |hyperref|
% \changes{v1.28}{2017/01/07}{Got rid of warnings in pdf keywords}
% \changes{v1.46}{2017/08/25}{Delayed hypersetup since journal options
% may change screen mode}
% \changes{v1.55}{2018/10/20}{Now we use purple color for links}
% \changes{v1.58}{2019/26/01}{Suppressed \cs{addtocounter} in pdf
% subject}
% \changes{1.85}{2022/05/08}{Added: acmengage}
% \begin{macrocode}
\let\@footnotemark@nolink\@footnotemark
\let\@footnotetext@nolink\@footnotetext
\RequirePackage[bookmarksnumbered,unicode]{hyperref}

Solution

Reverse the loading order of hyperref and hyperxmp.

@krono
Copy link
Contributor

krono commented Oct 14, 2023

This is already tracked i #505

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants