Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a prototype example docker-compose environment. #239

Closed
wants to merge 6 commits into from

Conversation

zorbathut
Copy link

This is very unfinished; it's basically what I put together from reading documentation. But man, having this would have made my setup a lot faster!

Suggestions and improvements welcome. I think having this is better than not having it, but there are absolutely ways to make it even better.

Closes #238 .

example/docker-compose.yml Outdated Show resolved Hide resolved
@zorbathut zorbathut requested a review from grantbevis June 20, 2023 11:57
@zorbathut
Copy link
Author

Don't know if anyone is out there, but I'd like to get this in!

@grantbevis
Copy link
Collaborator

What benefit does this bring over the documentation we already have? There's a example docker-compose already and the borgmatic documentation is top notch.

@zorbathut
Copy link
Author

Honestly, I didn't even see it when I was reading documentation, I think I'd ended up clicking on the modem7 link

However, it also isn't really a single self-contained example, it's kind of awkwardly interlaced with the base image definition. And the docker-compose that exists doesn't really provide much in the way of explanation for someone who doesn't already know how it works; a bunch of unfilled-out env variables doesn't help without sensible defaults.

(it's also out of date because it still includes .borgmatic)

I think an important goal for examples is an example that can be followed along and filled out, and that's what I'm going for here. Some people (like myself) work best from examples.

@grantbevis grantbevis closed this Sep 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add example docker-compose setup to repo?
3 participants