Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restart the current launcher when it is not xochitl #50

Open
mathias-sm opened this issue Dec 26, 2022 · 6 comments
Open

Restart the current launcher when it is not xochitl #50

mathias-sm opened this issue Dec 26, 2022 · 6 comments
Labels
enhancement New feature or request

Comments

@mathias-sm
Copy link

Thanks for this amazingly useful tool!

On my device, after each use of remy the UI was all messed up until the next reboot. This quote from the readme put me on the right track:

If Remy crashes and the remarkable seems unresponsive it is only because Remy re-enables the main UI of the tabled on exit; to regain control of the tablet you have three options: try and run Remy again and close it cleanly; or run ssh REMARKABLEHOST /bin/systemctl start xochitl; or manually reboot the device. Don't worry nothing bad is happening to the tablet in this circumstance.

As far as I can tell by xochitl is hardcoded, see here and here, maybe other places. However on my device I use remux and so restarting xochitl lead to a visual mess (I'm surprised it even works!)

As a quick fix, I hardcoded remux in remy/remarkable/filesource.py: so far it seems to work, but I imagine it would be worth either making it a configurable string in config.json, or executing systemctl on the device to know which launcher is running and restart that one.

Happy to try and draft a PR with either solution if you think it's worth it!

@iHnR
Copy link

iHnR commented May 27, 2023

I've also been having this problem. It seems like there's somehow two instances of xochitl running at the same time? A config of inference option would be really nice.

@bordaigorl bordaigorl added the enhancement New feature or request label May 27, 2023
@data-flux
Copy link

A more elegant solution than a config might be to use systemctl is-active with a list of launchers to check, remux, tarnish, draft, xochitl, and restarting the one that is actually running.

For now, I'm going to hardcode tarnish, but I'd love to see this feature, it is a major annoyance with what is otherwise the best gui interface for remarkable.

@data-flux
Copy link

Created a pull request

@bordaigorl
Copy link
Owner

Ah @data-flux thanks! I actually implemented this (using your suggestion about systemctl is-active) just haven't pushed it yet as I needed to add docs...
Should appear in devel by end of today

@data-flux
Copy link

Cheers!

I actually decided to use is-enabled, because is-active will fail if the user enables the banner function, I think.

@bordaigorl
Copy link
Owner

@data-flux could you test #57 ? It should work fine with the banner function too.

bordaigorl added a commit that referenced this issue Jun 27, 2023
Support custom launchers, fixes #50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants