-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add user accounts (fully optional) #79
Comments
User has email, password, username User page shows user reviews + all Hitchmap reviews made before the user creation date made with that same nickname + all reviews with same Hitchwiki username For the last two categories, add a disclaimer that these are not necessarily by the same person. Might even consider collapsing them |
I d advocate using hitchwiki accounts if possible. |
maybe like this https://www.mediawiki.org/wiki/OAuth/For_Developers |
I remember that getting a Hitchwiki account was a hassle, requiring manual verification by an admin. Hitchwiki also has super aggressive Cloudflare settings, so it might not be usable all around the world. Even regular Cloudflare settings might be too much for our user accounts, as we don't use it ourselves and some users/countries continue to have trouble with it. |
Also, like Hitchmap, Hitchwiki isn't funded at all and there's no guarantee it'll outlive Hitchmap. I'm cool with providing Hitchwiki logins as an option, but it shouldn't be the only option. |
Flask-Security, https://flask-security-too.readthedocs.io/en/stable/features.html , has recently been picked up by the core Flask team. I think is definitely the way to go now. |
In the initial implementation, I suggest:
Then, on the front-end:
|
hitchmap.com/#user:bob should also show reviews that were made under the nickname Bob (these were necessarily written before the user was registered) |
Alternatively, we can ask new users to select which reviews under the same nickname are theirs |
We've had quite a few requests for user pages with all of their reviews, so I guess it makes sense to add user accounts
No need to make them mandatory given the lack of spam/abuse
The text was updated successfully, but these errors were encountered: