Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

React.StrictMode giving a warnings, any plan to upgrade the code? #212

Open
1 of 2 tasks
gr8pathik opened this issue Jul 6, 2020 · 3 comments
Open
1 of 2 tasks

Comments

@gr8pathik
Copy link

gr8pathik commented Jul 6, 2020

v4

Before opening a new issue, please take a moment to review our community guidelines to make the contribution process easy and effective for everyone involved.

Before opening a new issue, you may find an answer in already closed issues:
https://github.com/bootstrap-styled/v4/issues?q=is%3Aissue+is%3Aclosed

Issue Type

Description

I am using lates version of React 16.13.1 and by default it has a React.StrictMode on but because of React.StrictMode mode it is giving an warnings as below
image (2)

Steps to reproduce

  • Use bootstrap-styled with latest React and enable React.StrictMode.

Versions

  • React 16.13.1

Is there any plan to upgrade this library anytime soon?

@kopax
Copy link
Contributor

kopax commented Jul 6, 2020

This normally have been fixed, we added all the suffix UNSAFE_, are you sure it's happening within bootstrap-styled latest?

Upgrade of the lib can be done by users and contributors, I won't personnaly do it as it's not blocking for us.

@rafaelsorto
Copy link

@kopax it's because React.StrictMode gives warning when there are UNSAFE methods being used. The solution would be to remove any UNSAFE lifecycle methods.

@kopax
Copy link
Contributor

kopax commented Jul 13, 2020

Ok. I'm not willing to do it as it is non blocking. I come up with two solutions:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants