do not alias rich text area if it is not defined #709
Conversation
BenMorganMY
changed the title
There was a problem hiding this comment.
Thanks for this PR. I really appreciate the time you're dedicating to make bootstrap_form better. I'm no expert on how Rails loads, but I'm guessing that when the tests run, our code is being run before rich_text_area is defined.
I really think we should get this to work the way you want it, but also have all the tests passing. Feel free to take a swing at it, or just comment back that you want someone else to take a run at it.
|
@lcreid I've switched from using the check to now just silencing the |
There was a problem hiding this comment.
I appreciate the effort you're putting into this. I think your approach is reasonable. I'm going to take a look at the problem as soon as I can and see if there's just something about the way we're loading that should be looked at. I suspect there is. This is not the first time we've had issues around loading the tests.
lib/bootstrap_form/inputs/base.rb
Outdated
| def bootstrap_alias(field_name) | ||
| alias_method "#{field_name}_without_bootstrap".to_sym, field_name | ||
| alias_method field_name, "#{field_name}_with_bootstrap".to_sym | ||
| rescue NameError |
There was a problem hiding this comment.
I'd prefer to do the RuboCop exception specifically on the line.
| rescue NameError | |
| rescue NameError # rubocop:disable Lint/SupressedException |
.rubocop.yml
Outdated
| Lint/SuppressedException: | ||
| Enabled: false | ||
|
|
There was a problem hiding this comment.
See below.
| Lint/SuppressedException: | |
| Enabled: false |
| @@ -45,6 +48,7 @@ Metrics/AbcSize: | |||
|
|
|||
| Metrics/BlockLength: | |||
| Exclude: | |||
| - "lib/bootstrap_form/inputs/base.rb" | |||
There was a problem hiding this comment.
I guess we can leave this one in here, since it applies to the whole file anyway. But I should look at the rule and where it came from. I'm a fan of RuboCop, but not of these rules that put arbitrary limits on the size of things.
|
@lcreid updated the rubocop lint suppression suggestion. |
BenMorganMY
deleted the
fix-bootstrap-alias-with-actiontext-not-present
branch
We experienced an error with eager loading in staging for bootstrap_form. This small if statement resolves that issue.